[Digikam-users] undo/redo in editor is not working in digikam 3.4

[Gilles Caulier]

Implemented.

http://commits.kde.org/digikam/5cac0a5f7c911392abdaec28ec776510e9284688

In fact the cache action not registered and not performed and will not
appears in editor menu...

It's the most quick fix that i can do for this problem.

Note that i check if a least a space of 1Gb is available to perform
undo action. I think it's enough for most of case here. Right ?

I hope that no side effect will be introduced.

Note : from the console editor will print free space available in
cache. Under OSX, it look like this after applying an autoColor
Correction :

digikam(12210)/digikam (core)
Digikam::EditorToolThreaded::slotPreview: Preview  "Auto Correction"
started...
digikam(12210)/digikam (core)
Digikam::EditorToolThreaded::slotFilterFinished: Preview  "Auto
Correction"  completed...
digikam(12210)/digikam (core)
Digikam::WBFilter::autoExposureAdjustement: White level at: 249
digikam(12210)/digikam (core)
Digikam::WBFilter::autoExposureAdjustement: Black: 0.0410156
Exposition: 0.0342157
digikam(12210)/digikam (core) Digikam::WBFilter::setLUTv: T(K):  6500
=> R: 1  G:    1  B:    1  BP:   10  WP:   250
digikam(12210)/digikam (core)
Digikam::EditorToolThreaded::slotPreview: Preview  "Auto Correction"
started...
digikam(12210)/digikam (core)
Digikam::EditorToolThreaded::slotFilterFinished: Preview  "Auto
Correction"  completed...
digikam(12210)/digikam (core) Digikam::EditorToolThreaded::slotOk:
Final  "Auto Correction"  started...
digikam(12210)/digikam (core)
Digikam::EditorToolThreaded::slotFilterFinished: Final "Auto
Correction"  completed...
digikam(12210)/digikam (core) Digikam::UndoCache::putData: Free space
available in Editor cache [
"/private/var/tmp/kdecache-gilles/digiKam/" ] in Mbytes:  120418

Gilles


2013/9/22 Anders Lund <anders at alweb.dk>:
> Maybe there is somewhere an error message if you try to write more data than
> possible?
>
> On Søndag den 22. september 2013 20:33:14, Gilles Caulier wrote:
>> I will be more precise here.
>>
>> In code we use KStandardDir::localeLocal('cache",...) to get temprary
>> dir to store uno/redo files :
>>
>> https://projects.kde.org/projects/extragear/graphics/digikam/repository/revi
>> sions/master/entry/utilities/imageeditor/core/undocache.cpp#L69
>>
>> KStandardDir has no way to check free-space :
>>
>> http://www.purinchu.net/kdelibs-apidocs/kdecore/html/classKStandardDirs.html
>>
>> But i remember that we have already a method in Import Tool to show
>> free space from camera and collection. KDiskFreeSpaceInfo must do the
>> stuff :
>>
>> http://api.kde.org/4.x-api/kdelibs-apidocs/kio/html/kdiskfreespaceinfo_8h.ht
>> ml
>
> That looks like good information
>
> --
> Anders
> _______________________________________________
> Digikam-users mailing list
> Digikam-users at kde.org
> https://mail.kde.org/mailman/listinfo/digikam-users