[Digikam-users] digikam-0.9.1 and japser

[Gilles Caulier]

2007/3/6, Achim Bohnet <ach at mpe.mpg.de>:
>
> On Tuesday, 6. March 2007, Dennis Veatch wrote:
> > On Tuesday 06 March 2007 07:27:53 am Arnd Baecker wrote:
> > > On Mon, 5 Mar 2007, Dennis Veatch wrote:
> > >
> > > [...]
> > >
> > > > Your right, did not realize jasper does not build .so by default.
> > >
> > > Me neither, Fabien and Achim helped me through that
> > > on the developers mailing list ;-)
> > > (Funnily, it used to work before ...)
> >
> > Yah that was my confusion because the 0.9.0 configure had no issues with
> that
> > and no other apps that can use it barked about it.... at least not that
> I
> > have found yet.
>
> that made me curious. and I greped 0.9 and 0.9.1 configure
>
> $ grep -i jasper 0.9.0/digikam-0.9.0/digikam/configure.in.in 0.9.1
> /digikam-0.9.1/digikam/configure.in.in
> 0.9.1/digikam-0.9.1/digikam/configure.in.in:# Check for libjasper
> (JPEG2000)
> 0.9.1/digikam-0.9.1/digikam/configure.in.in:have_jasper=no
> 0.9.1/digikam-0.9.1/digikam/configure.in.in:KDE_CHECK_LIB(jasper,
> jas_init,
> 0.9.1/digikam-0.9.1/digikam/configure.in.in:              have_jasper=yes,
> 0.9.1/digikam-0.9.1/digikam/configure.in.in:              AC_MSG_WARN([digiKam
> requires libjasper >= 1.7.0]),
> 0.9.1/digikam-0.9.1/digikam/configure.in.in:              -ljasper)
> 0.9.1/digikam-0.9.1/digikam/configure.in.in:if test "x$have_jasper" !=
> "xyes"; then
> 0.9.1/digikam-0.9.1/digikam/configure.in.in:  AC_WARN([digiKam requires
> libjasper >= 1.7.0; digiKam will not be compiled.])
> 0.9.1/digikam-0.9.1/digikam/configure.in.in:  LIB_JASPER="-ljasper"
> 0.9.1/digikam-0.9.1/digikam/configure.in.in:  AC_SUBST(LIB_JASPER)
>
> so 0.9.0 had no check for libjasper at all ;)


Absolutly. I have added jasper depency only with 0.9.1 release

grep -i jasper 0.9.0/digikam-0.9.0/README   find also nothing.
> So my naive summary is that digikam did not use libjasper in 0.9.0
>
> Searching recursively for jasper uncovered:
> 0.9.0/digikam-0.9.0/acinclude.m4:AC_DEFUN([AC_FIND_JASPER],
> 0.9.0/digikam-0.9.0/acinclude.m4:AC_MSG_CHECKING([for jasper])
> 0.9.0/digikam-0.9.0/acinclude.m4:AC_CACHE_VAL(ac_cv_jasper,
> 0.9.0/digikam-0.9.0/acinclude.m4:LIBS="$LIBS $all_libraries $USER_LDFLAGS
> -ljasper $LIBJPEG -lm"
> 0.9.0/digikam-0.9.0/acinclude.m4:    #include<jasper/jasper.h>
> 0.9.0/digikam-0.9.0/acinclude.m4:    eval "ac_cv_jasper='-ljasper $LIBJPEG
> -lm'",
> 0.9.0/digikam-0.9.0/acinclude.m4:    eval "ac_cv_jasper=no"
> 0.9.0/digikam-0.9.0/acinclude.m4:if eval "test ! \"`echo $ac_cv_jasper`\"
> = no"; then
> 0.9.0/digikam-0.9.0/acinclude.m4:  AC_DEFINE_UNQUOTED(HAVE_JASPER, 1,
> [Define if you have jasper])
> 0.9.0/digikam-0.9.0/acinclude.m4:  LIB_JASPER="$ac_cv_jasper"
> 0.9.0/digikam-0.9.0/acinclude.m4:  AC_MSG_RESULT($ac_cv_jasper)
> 0.9.0/digikam-0.9.0/acinclude.m4:  LIB_JASPER=""
> 0.9.0/digikam-0.9.0/acinclude.m4:AC_SUBST(LIB_JASPER)
>
> as this check mentions  $LIBJPEG and -lm, which were the problem is
> the static libjasper build AFAIR, I assume digikam should use
> AC_FIND_JASPER
> instead it's home grown test?


Well if it work why not...

Gilles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-users/attachments/20070307/94b82f82/attachment.html>