New Defects reported by Coverity Scan for digiKam
scan-admin at coverity.com
scan-admin at coverity.com
Tue Oct 27 05:22:08 GMT 2026
Hi,
Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.
3 new defect(s) introduced to digiKam found with Coverity Scan.
113 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1704175: (FORWARD_NULL)
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 975 in LibRaw::GetNormalizedModel()()
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 949 in LibRaw::GetNormalizedModel()()
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 858 in LibRaw::GetNormalizedModel()()
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 1043 in LibRaw::GetNormalizedModel()()
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 829 in LibRaw::GetNormalizedModel()()
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 1106 in LibRaw::GetNormalizedModel()()
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 910 in LibRaw::GetNormalizedModel()()
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 921 in LibRaw::GetNormalizedModel()()
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 995 in LibRaw::GetNormalizedModel()()
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 813 in LibRaw::GetNormalizedModel()()
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 893 in LibRaw::GetNormalizedModel()()
_____________________________________________________________________________________________
*** CID 1704175: (FORWARD_NULL)
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 975 in LibRaw::GetNormalizedModel()()
969 i < int(sizeof SamsungPentax_aliases / sizeof *SamsungPentax_aliases);
970 i++) {
971 if (SamsungPentax_aliases[i][0] == '@') {
972 orig = SamsungPentax_aliases[i] + 1;
973 if (!strcmp(model, orig)) break;
974 } else if (!strcmp(model, SamsungPentax_aliases[i])) {
>>> CID 1704175: (FORWARD_NULL)
>>> Passing null pointer "orig" to "strcpy", which dereferences it.
975 strcpy(normalized_model, orig);
976 break;
977 }
978 }
979 if (!strncmp(model, "GR", 2)) {
980 setMakeFromIndex(LIBRAW_CAMERAMAKER_Ricoh);
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 949 in LibRaw::GetNormalizedModel()()
943 orig = panalias[i] + 1;
944 if (!strcmp(model, orig)) break;
945 }
946 else if (!strcmp(model, panalias[i]))
947 {
948 setMakeFromIndex(LIBRAW_CAMERAMAKER_Panasonic);
>>> CID 1704175: (FORWARD_NULL)
>>> Passing null pointer "orig" to "strcpy", which dereferences it.
949 strcpy(normalized_model, orig);
950 break;
951 }
952 }
953 } else if (makeIs(LIBRAW_CAMERAMAKER_Pentax)) {
954 if (!unique_id) {
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 858 in LibRaw::GetNormalizedModel()()
852 {
853 orig = leafalias[i] + 1;
854 if (!strcmp(model, orig)) break;
855 }
856 else if (!strcmp(model, leafalias[i]))
857 { // maybe to change regular "make" to "Mamiya" too
>>> CID 1704175: (FORWARD_NULL)
>>> Passing null pointer "orig" to "strcpy", which dereferences it.
858 strcpy(normalized_model, orig);
859 break;
860 }
861 }
862 if ((ps = strchr(normalized_model, '(')))
863 *ps = 0;
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 1043 in LibRaw::GetNormalizedModel()()
1037 {
1038 orig = samsungalias[i] + 1;
1039 if (!strcmp(model, orig)) break;
1040 }
1041 else if (!strcmp(model, samsungalias[i]))
1042 {
>>> CID 1704175: (FORWARD_NULL)
>>> Passing null pointer "orig" to "strcpy", which dereferences it.
1043 strcpy(normalized_model, orig);
1044 break;
1045 }
1046 }
1047 }
1048
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 829 in LibRaw::GetNormalizedModel()()
823 for (i = 0; i < int(sizeof phase1alias / sizeof *phase1alias); i++)
824 { // re-badged Phase One backs
825 if (phase1alias[i][0] == '@') orig = phase1alias[i] + 1;
826 else if (!strcmp(model, phase1alias[i]))
827 {
828 setMakeFromIndex(LIBRAW_CAMERAMAKER_PhaseOne);
>>> CID 1704175: (FORWARD_NULL)
>>> Passing null pointer "orig" to "strcpy", which dereferences it.
829 strcpy(normalized_model, orig);
830 break;
831 }
832 }
833 for (i = 0; i < int(sizeof leafalias / sizeof *leafalias); i++)
834 { // re-badged Leaf backs
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 1106 in LibRaw::GetNormalizedModel()()
1100 {
1101 orig = kodakalias[i] + 1;
1102 if (!strcmp(model, orig)) break;
1103 }
1104 else if (!strcmp(model, kodakalias[i]))
1105 {
>>> CID 1704175: (FORWARD_NULL)
>>> Passing null pointer "orig" to "strcpy", which dereferences it.
1106 strcpy(normalized_model, orig);
1107 break;
1108 }
1109 }
1110
1111 if (strstr(model, "DC25"))
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 910 in LibRaw::GetNormalizedModel()()
904 {
905 orig = nikonalias[i] + 1;
906 if (!strcmp(model, orig)) break;
907 }
908 else if (!strcmp(model, nikonalias[i]))
909 {
>>> CID 1704175: (FORWARD_NULL)
>>> Passing null pointer "orig" to "strcpy", which dereferences it.
910 strcpy(normalized_model, orig);
911 break;
912 }
913 }
914
915 } else if (makeIs(LIBRAW_CAMERAMAKER_Olympus)) {
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 921 in LibRaw::GetNormalizedModel()()
915 } else if (makeIs(LIBRAW_CAMERAMAKER_Olympus)) {
916 for (i = 0; i < int(sizeof olyalias / sizeof *olyalias); i++) {
917 if (olyalias[i][0] == '@') {
918 orig = olyalias[i] + 1;
919 if (!strcmp(model, orig)) break;
920 } else if (!strcmp(model, olyalias[i])) {
>>> CID 1704175: (FORWARD_NULL)
>>> Passing null pointer "orig" to "strcpy", which dereferences it.
921 strcpy(normalized_model, orig);
922 break;
923 }
924 }
925
926 if (!OlyID) {
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 995 in LibRaw::GetNormalizedModel()()
989 {
990 orig = phase1alias[i] + 1;
991 if (!strcmp(model, orig)) break;
992 }
993 else if (!strcmp(model, phase1alias[i]))
994 {
>>> CID 1704175: (FORWARD_NULL)
>>> Passing null pointer "orig" to "strcpy", which dereferences it.
995 strcpy(normalized_model, orig);
996 break;
997 }
998 }
999 if (strstr(imPhaseOne.FirmwareString, "Achromatic"))
1000 {
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 813 in LibRaw::GetNormalizedModel()()
807 {
808 orig = fujialias[i] + 1;
809 if (!strcmp(model, orig)) break;
810 }
811 else if (!strcmp(model, fujialias[i]))
812 {
>>> CID 1704175: (FORWARD_NULL)
>>> Passing null pointer "orig" to "strcpy", which dereferences it.
813 strcpy(normalized_model, orig);
814 break;
815 }
816 }
817
818 } else if (makeIs(LIBRAW_CAMERAMAKER_Hasselblad)) {
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/src/metadata/normalize_model.cpp: 893 in LibRaw::GetNormalizedModel()()
887 }
888 }
889 else if (!strcasecmp(model, KonicaMinolta_aliases[i]))
890 {
891 setMakeFromIndex(LIBRAW_CAMERAMAKER_Minolta);
892 strcpy(make, "Minolta");
>>> CID 1704175: (FORWARD_NULL)
>>> Passing null pointer "orig" to "strcpy", which dereferences it.
893 strcpy(normalized_model, orig);
894 break;
895 }
896 }
897 }
898 }
** CID 1704174: Error handling issues (UNCAUGHT_EXCEPT)
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/samples/mem_image_sample.cpp: 142 in main()
_____________________________________________________________________________________________
*** CID 1704174: Error handling issues (UNCAUGHT_EXCEPT)
/home/gilles/Devel/9.x/core/libs/rawengine/libraw/samples/mem_image_sample.cpp: 142 in main()
136 return;
137 fwrite(img->data, img->data_size, 1, f);
138 fclose(f);
139 }
140 }
141
>>> CID 1704174: Error handling issues (UNCAUGHT_EXCEPT)
>>> In function "main(int, char **)" an exception of type "LibRaw_exceptions" is thrown and never caught.
142 int main(int ac, char *av[])
143 {
144 int i, ret, output_thumbs = 0;
145 #ifdef USE_JPEG
146 int output_jpeg = 0, jpgqual = 90;
147 #endif
** CID 1704173: Control flow issues (DEADCODE)
/home/gilles/Devel/9.x/core/dplugins/generic/webservices/immich/immichxmp.h: 295 in DigikamGenericImmichPlugin::mergeSidecarPackets(const QString &, const QString &, const QList<QString> &)()
_____________________________________________________________________________________________
*** CID 1704173: Control flow issues (DEADCODE)
/home/gilles/Devel/9.x/core/dplugins/generic/webservices/immich/immichxmp.h: 295 in DigikamGenericImmichPlugin::mergeSidecarPackets(const QString &, const QString &, const QList<QString> &)()
289 preserved += QStringLiteral(" ");
290 copySubtree();
291 preserved += QLatin1Char('\n');
292 }
293 else
294 {
>>> CID 1704173: Control flow issues (DEADCODE)
>>> Execution cannot reach this statement: "++depth;".
295 ++depth;
296 }
297 }
298 else if (reader.tokenType() == QXmlStreamReader::EndElement)
299 {
300 --depth;
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/digikam?tab=overview
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20261027/a1b70f64/attachment-0001.htm>
More information about the Digikam-devel
mailing list