New Defects reported by Coverity Scan for digiKam
scan-admin at coverity.com
scan-admin at coverity.com
Sun Nov 22 06:03:12 GMT 2026
Hi,
Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.
4 new defect(s) introduced to digiKam found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)
** CID 1709644: Null pointer dereferences (FORWARD_NULL)
_____________________________________________________________________________________________
*** CID 1709644: Null pointer dereferences (FORWARD_NULL)
/mnt/data/Devel/9.x/core/tests/database/albummanager_utest.cpp: 671 in TestAlbumManager::testDeleteCurrentPAlbum()()
665 }
666
667 QVERIFY2(parent, "No album root found for the collection");
668
669 const QString albumName = QLatin1String("CurrentPAlbum-")
670 + QTime::currentTime().toString(QLatin1String("hhmmsszzz"));
>>> CID 1709644: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "parent" to "folderPath", which dereferences it.
671 m_palbumFolderPath = QDir(parent->folderPath()).filePath(albumName);
672
673 QString errMsg;
674 PAlbum* const album = manager->createPAlbum(parent, albumName,
675 QString(), QDate(2020, 1, 1),
676 QLatin1String("Test"), errMsg);
** CID 1709643: Incorrect expression (COPY_PASTE_ERROR)
/mnt/data/Devel/9.x/core/libs/dimg/filters/icc/iccmanager.cpp: 304 in Digikam::IccManager::getTransform(Digikam::IccTransform &, QFlags<Digikam::ICCSettingsContainer::BehaviorEnum>, const Digikam::IccProfile &)()
_____________________________________________________________________________________________
*** CID 1709643: Incorrect expression (COPY_PASTE_ERROR)
/mnt/data/Devel/9.x/core/libs/dimg/filters/icc/iccmanager.cpp: 304 in Digikam::IccManager::getTransform(Digikam::IccTransform &, QFlags<Digikam::ICCSettingsContainer::BehaviorEnum>, const Digikam::IccProfile &)()
298 {
299 setIccProfile(inputProfile);
300 }
301
302 if (!outputProfile.isNull())
303 {
>>> CID 1709643: Incorrect expression (COPY_PASTE_ERROR)
>>> "inputProfile" looks like a copy-paste error.
304 trans.setInputProfile(inputProfile);
305 trans.setOutputProfile(outputProfile);
306 }
307 else if ((inputProfile != d->embeddedProfile) &&
308 !(behavior & ICCSettingsContainer::ConvertToWorkspace) &&
309 !(behavior & ICCSettingsContainer::LeaveFileUntagged))
** CID 1709642: (OVERRUN)
_____________________________________________________________________________________________
*** CID 1709642: (OVERRUN)
/mnt/data/Devel/9.x/core/libs/pgfutils/libpgf/Decoder.cpp: 724 in pgf::CDecoder::CMacroBlock::BitplaneDecode()()
718 uint32_t sigPos = AlignWordPos(signPos + codeLen); ASSERT(sigPos < CodeBufferBitLen);
719
720 // refinement bits
721 codePos = AlignWordPos(sigPos + sigLen); ASSERT(codePos < CodeBufferBitLen);
722
723 // read significant and refinement bitset from m_codeBuffer
>>> CID 1709642: (OVERRUN)
>>> Overrunning array of 16384 4-byte elements at element index 134217727 (byte offset 536870911) by dereferencing pointer "&this->m_codeBuffer[codePos >> 5U]".
724 sigLen = ComposeBitplaneRLD(bufferSize, planeMask, &m_codeBuffer[sigPos >> WordWidthLog], &m_codeBuffer[codePos >> WordWidthLog], signPos);
725
726 } else {
727 // RL coding of signBits was not efficient and therefore not used
728 // <0><signLen>_<signBits>_<sigBits>_<refBits>
729 codePos++;
/mnt/data/Devel/9.x/core/libs/pgfutils/libpgf/Decoder.cpp: 744 in pgf::CDecoder::CMacroBlock::BitplaneDecode()()
738 uint32_t sigPos = AlignWordPos(signPos + signLen); ASSERT(sigPos < CodeBufferBitLen);
739
740 // refinement bits
741 codePos = AlignWordPos(sigPos + sigLen); ASSERT(codePos < CodeBufferBitLen);
742
743 // read significant and refinement bitset from m_codeBuffer
>>> CID 1709642: (OVERRUN)
>>> Overrunning array of 16384 4-byte elements at element index 134217727 (byte offset 536870911) by dereferencing pointer "&this->m_codeBuffer[signPos >> 5U]".
744 sigLen = ComposeBitplane(bufferSize, planeMask, &m_codeBuffer[sigPos >> WordWidthLog], &m_codeBuffer[codePos >> WordWidthLog], &m_codeBuffer[signPos >> WordWidthLog]);
745 }
746 }
747
748 // start of next chunk
749 codePos = AlignWordPos(codePos + bufferSize - sigLen); ASSERT(codePos < CodeBufferBitLen);
/mnt/data/Devel/9.x/core/libs/pgfutils/libpgf/Decoder.cpp: 694 in pgf::CDecoder::CMacroBlock::BitplaneDecode()()
688
689 // refinement bits
690 codePos = AlignWordPos(sigPos + codeLen); ASSERT(codePos < CodeBufferBitLen);
691
692 // run-length decode significant bits and signs from m_codeBuffer and
693 // read refinement bits from m_codeBuffer and compose bit plane
>>> CID 1709642: (OVERRUN)
>>> Overrunning array of 16384 4-byte elements at element index 134217727 (byte offset 536870911) by dereferencing pointer "&this->m_codeBuffer[codePos >> 5U]".
694 sigLen = ComposeBitplaneRLD(bufferSize, planeMask, sigPos, &m_codeBuffer[codePos >> WordWidthLog]);
695
696 } else {
697 // no RL coding is used for sigBits and signBits together
698 // <0><sigLen>
699 codePos++;
/mnt/data/Devel/9.x/core/libs/pgfutils/libpgf/Decoder.cpp: 744 in pgf::CDecoder::CMacroBlock::BitplaneDecode()()
738 uint32_t sigPos = AlignWordPos(signPos + signLen); ASSERT(sigPos < CodeBufferBitLen);
739
740 // refinement bits
741 codePos = AlignWordPos(sigPos + sigLen); ASSERT(codePos < CodeBufferBitLen);
742
743 // read significant and refinement bitset from m_codeBuffer
>>> CID 1709642: (OVERRUN)
>>> Overrunning array of 16384 4-byte elements at element index 134217727 (byte offset 536870911) by dereferencing pointer "&this->m_codeBuffer[codePos >> 5U]".
744 sigLen = ComposeBitplane(bufferSize, planeMask, &m_codeBuffer[sigPos >> WordWidthLog], &m_codeBuffer[codePos >> WordWidthLog], &m_codeBuffer[signPos >> WordWidthLog]);
745 }
746 }
747
748 // start of next chunk
749 codePos = AlignWordPos(codePos + bufferSize - sigLen); ASSERT(codePos < CodeBufferBitLen);
** CID 1709641: Memory - corruptions (OVERRUN)
/mnt/data/Devel/9.x/core/libs/pgfutils/libpgf/Encoder.cpp: 330 in pgf::CEncoder::WriteValue(pgf::CSubband *, int)()
_____________________________________________________________________________________________
*** CID 1709641: Memory - corruptions (OVERRUN)
/mnt/data/Devel/9.x/core/libs/pgfutils/libpgf/Encoder.cpp: 330 in pgf::CEncoder::WriteValue(pgf::CSubband *, int)()
324 // If buffer is full encode it to file
325 // It might throw an IOException.
326 void CEncoder::WriteValue(CSubband* band, int bandPos) {
327 if (m_currentBlock->m_valuePos == BufferSize) {
328 EncodeBuffer(ROIBlockHeader(BufferSize, false));
329 }
>>> CID 1709641: Memory - corruptions (OVERRUN)
>>> Overrunning array "this->m_currentBlock->m_value" of 16384 4-byte elements at element index 16384 (byte offset 65539) using index "this->m_currentBlock->m_valuePos++" (which evaluates to 16384).
330 DataT val = m_currentBlock->m_value[m_currentBlock->m_valuePos++] = band->GetData(bandPos);
331 uint32_t v = abs(val);
332 if (v > m_currentBlock->m_maxAbsValue) m_currentBlock->m_maxAbsValue = v;
333 }
334
335 /////////////////////////////////////////////////////////////////////
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/digikam?tab=overview
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20261122/3751e707/attachment.htm>
More information about the Digikam-devel
mailing list