New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

2 new defect(s) introduced to digiKam found with Coverity Scan.
13 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1634403:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/home/gilles/devel/GIT/8.x/core/libs/dnnmodelmanager/dnnmodelmanager.cpp: 268 in Digikam::DNNModelManager::getSettings()()


________________________________________________________________________________________________________
*** CID 1634403:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/home/gilles/devel/GIT/8.x/core/libs/dnnmodelmanager/dnnmodelmanager.cpp: 268 in Digikam::DNNModelManager::getSettings()()
262             // Env var for tuning model settings.
263     
264             QString dnnModelConf    = QString::fromLocal8Bit(qgetenv("DIGIKAM_DNN_MODEL_CONF"));
265     
266             if (0 < dnnModelConf.length())
267             {
>>>     CID 1634403:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "dnnModelConf" is copied in a call to copy assignment "operator =", when it could be moved instead.
268                 appPath = dnnModelConf;
269             }
270     
271             if (!appPath.isEmpty())
272             {
273                 d->settings     = new QSettings(appPath, QSettings::IniFormat, this);

** CID 1634402:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/home/gilles/devel/GIT/8.x/core/libs/metadataengine/engine/metaengine_item.cpp: 1454 in Digikam::MetaEngine::setItemIccProfile(const QByteArray &) const()


________________________________________________________________________________________________________
*** CID 1634402:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/home/gilles/devel/GIT/8.x/core/libs/metadataengine/engine/metaengine_item.cpp: 1454 in Digikam::MetaEngine::setItemIccProfile(const QByteArray &) const()
1448                 d->iccProfileBuf().reset();
1449     
1450                 return true;
1451             }
1452     
1453             Exiv2::DataBuf buf((Exiv2::byte*)iccData.data(), iccData.size());
>>>     CID 1634402:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "buf" is copied in a call to copy assignment "operator =", when it could be moved instead.
1454             d->iccProfileBuf() = buf;
1455     
1456             return true;
1457         }
1458         catch (Exiv2::AnyError& e)
1459         {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4yJUfIaFVfulX1EnArvLvmGJ18AyhOhOJnWywYkUuR-2BHL458rbL5b5DiAzhSjilZ8-3DKCbH_wUwU8mg96yc-2FA1IAMQ6mJ-2FFdQ9EM-2BFY-2BXFbSpXNYnfwwVCztoSr45peP97GXosDr-2FX-2BGfLZyHFj0uCxtEmM-2FEbh4hyfkHG1Ld72w7zKYTYG4VVTMfkMPb13Nlz8sNiB7NRBuaDEsYa0vsq6V6jGvaXo7SWrkWPE-2FUDybZDJmPZeUrAsh3-2F6TTXNthKJUF-2BBgLe2SFlmhNxvpX5s9KaNV2w-3D-3D