New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

2 new defect(s) introduced to digiKam found with Coverity Scan.
123 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1496841:  Control flow issues  (STRAY_SEMICOLON)
/home/gilles/Devel/7.x/core/libs/album/manager/albummanager_talbum.cpp: 573 in Digikam::AlbumManager::mergeTAlbum(Digikam::TAlbum *, Digikam::TAlbum *, bool, QString &)()


________________________________________________________________________________________________________
*** CID 1496841:  Control flow issues  (STRAY_SEMICOLON)
/home/gilles/Devel/7.x/core/libs/album/manager/albummanager_talbum.cpp: 573 in Digikam::AlbumManager::mergeTAlbum(Digikam::TAlbum *, Digikam::TAlbum *, bool, QString &)()
567         if (album == d->rootTAlbum || destAlbum == d->rootTAlbum)
568         {
569             errMsg = i18n("Cannot merge root tag");
570             return false;
571         }
572     
>>>     CID 1496841:  Control flow issues  (STRAY_SEMICOLON)
>>>     An "if" statement with no "then" or "else" is suspicious.
573         if (FaceTags::isSystemPersonTagId(album->id()));
574         {
575             errMsg = i18n("Cannot merge required face tag");
576             return false;
577         }
578     

** CID 1496840:  Control flow issues  (UNREACHABLE)
/home/gilles/Devel/7.x/core/libs/album/manager/albummanager_talbum.cpp: 579 in Digikam::AlbumManager::mergeTAlbum(Digikam::TAlbum *, Digikam::TAlbum *, bool, QString &)()


________________________________________________________________________________________________________
*** CID 1496840:  Control flow issues  (UNREACHABLE)
/home/gilles/Devel/7.x/core/libs/album/manager/albummanager_talbum.cpp: 579 in Digikam::AlbumManager::mergeTAlbum(Digikam::TAlbum *, Digikam::TAlbum *, bool, QString &)()
573         if (FaceTags::isSystemPersonTagId(album->id()));
574         {
575             errMsg = i18n("Cannot merge required face tag");
576             return false;
577         }
578     
>>>     CID 1496840:  Control flow issues  (UNREACHABLE)
>>>     This code cannot be reached: "if (album->firstChild()) {
...".
579         if (album->firstChild())
580         {
581             errMsg = i18n("Only a tag without children can be merged!");
582             return false;
583         }
584     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp2OAl-2Fauo86CB28HCT0-2BnD-2F6eFMYt863B1-2B0FLvU5y-2FRWSl8rMA4vGwCkGPp0f1hg-3DiMdy_IpEMwFcbl-2BY9RHaL2m6a3nuAxB4hfm4MTniX0gHjADVTI-2F7IOimjiH7Cb-2BBODV8fS1Me9MXMBTZeOzyAAqlKxwn2zeL0QsLfuHCXqAcL5cGQvqpfIolPOKs58Q0J1T9tEbYS-2FWwrvVzD9XgQG4exQNNRD-2B1s19biIJXAIeu5c0MSRqduKha5Wj-2FHeDksQPvF8RmB8LRsneN-2FmJ0JgtEiYA-3D-3D