New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

5 new defect(s) introduced to digiKam found with Coverity Scan.
215 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1485159:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Devel/7.x/core/dplugins/generic/tools/htmlgallery/generator/galleryxmlutils.cpp: 60 in DigikamGenericHtmlGalleryPlugin::XMLWriter::writeElement(const char *, const QString &)()


________________________________________________________________________________________________________
*** CID 1485159:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Devel/7.x/core/dplugins/generic/tools/htmlgallery/generator/galleryxmlutils.cpp: 60 in DigikamGenericHtmlGalleryPlugin::XMLWriter::writeElement(const char *, const QString &)()
54     {
55         return m_writer;
56     }
57     
58     void XMLWriter::writeElement(const char* element, const QString& value)
59     {
>>>     CID 1485159:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "xmlTextWriterWriteElement(this->m_writer.operator xmlTextWriterPtr(), (xmlChar *)element, (xmlChar *)QByteArray(value->toUtf8()).data())" without checking return value. This library function may fail and return an error code.
60         xmlTextWriterWriteElement(m_writer, BAD_CAST element, BAD_CAST value.toUtf8().data());
61     }
62     
63     void XMLWriter::writeElement(const char* element, int value)
64     {
65         writeElement(element, QString::number(value));

** CID 1485158:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Devel/7.x/core/dplugins/generic/tools/htmlgallery/generator/galleryxmlutils.cpp: 98 in DigikamGenericHtmlGalleryPlugin::XMLElement::XMLElement(DigikamGenericHtmlGalleryPlugin::XMLWriter &, const QString &, const DigikamGenericHtmlGalleryPlugin::XMLAttributeList *)()


________________________________________________________________________________________________________
*** CID 1485158:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Devel/7.x/core/dplugins/generic/tools/htmlgallery/generator/galleryxmlutils.cpp: 98 in DigikamGenericHtmlGalleryPlugin::XMLElement::XMLElement(DigikamGenericHtmlGalleryPlugin::XMLWriter &, const QString &, const DigikamGenericHtmlGalleryPlugin::XMLAttributeList *)()
92     
93     // ------------------------------------------------------
94     
95     XMLElement::XMLElement(XMLWriter& writer, const QString& element, const XMLAttributeList* attributeList)
96         : m_writer(writer)
97     {
>>>     CID 1485158:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "xmlTextWriterStartElement(writer->operator xmlTextWriterPtr(), (xmlChar *)QByteArray(element->toLatin1()).data())" without checking return value. This library function may fail and return an error code.
98         xmlTextWriterStartElement(writer, BAD_CAST element.toLatin1().data());
99     
100         if (attributeList)
101         {
102             attributeList->write(writer);
103         }

** CID 1485157:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Devel/7.x/core/dplugins/generic/tools/htmlgallery/generator/galleryxmlutils.cpp: 77 in DigikamGenericHtmlGalleryPlugin::XMLAttributeList::write(DigikamGenericHtmlGalleryPlugin::XMLWriter &) const()


________________________________________________________________________________________________________
*** CID 1485157:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Devel/7.x/core/dplugins/generic/tools/htmlgallery/generator/galleryxmlutils.cpp: 77 in DigikamGenericHtmlGalleryPlugin::XMLAttributeList::write(DigikamGenericHtmlGalleryPlugin::XMLWriter &) const()
71     {
72         Map::const_iterator it  = m_map.begin();
73         Map::const_iterator end = m_map.end();
74     
75         for (; it != end ; ++it)
76         {
>>>     CID 1485157:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "xmlTextWriterWriteAttribute(writer->operator xmlTextWriterPtr(), (xmlChar *)QByteArray(it.key()->toLatin1()).data(), (xmlChar *)QByteArray(it.value()->toLatin1()).data())" without checking return value. This library function may fail and return an error code.
77             xmlTextWriterWriteAttribute(writer,
78                                         BAD_CAST it.key().toLatin1().data(),
79                                         BAD_CAST it.value().toLatin1().data());
80         }
81     }
82     

** CID 1485156:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Devel/7.x/core/dplugins/generic/webservices/inaturalist/inatutils.cpp: 80 in DigikamGenericINatPlugin::getMultiPart(const QList<QPair<QString, QString>> &, const QString &, const QString &)()


________________________________________________________________________________________________________
*** CID 1485156:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Devel/7.x/core/dplugins/generic/webservices/inaturalist/inatutils.cpp: 80 in DigikamGenericINatPlugin::getMultiPart(const QList<QPair<QString, QString>> &, const QString &, const QString &)()
74                                 QVariant(QString(QLatin1String("image/%1")).
75                                          arg(fileInfo.suffix().toLower())));
76             imagePart.setHeader(QNetworkRequest::ContentDispositionHeader,
77                                 QVariant(imageForm.arg(imageName,
78                                          fileInfo.baseName())));
79             QFile* file = new QFile(imagePath);
>>>     CID 1485156:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "open" without checking return value (as is done elsewhere 40 out of 41 times).
80             file->open(QIODevice::ReadOnly);
81             imagePart.setBodyDevice(file);
82             file->setParent(result);
83             result->append(imagePart);
84         }
85     

** CID 1485155:  Resource leaks  (VIRTUAL_DTOR)
/home/gilles/Devel/7.x/core/libs/metadataengine/engine/metaengine.h: 57 in ()


________________________________________________________________________________________________________
*** CID 1485155:  Resource leaks  (VIRTUAL_DTOR)
/home/gilles/Devel/7.x/core/libs/metadataengine/engine/metaengine.h: 57 in ()
51     
52     namespace Digikam
53     {
54     
55     // TODO: merge with DMetadata class.
56     
>>>     CID 1485155:  Resource leaks  (VIRTUAL_DTOR)
>>>     Class "Digikam::MetaEngine" does not have a virtual destructor.
57     class DIGIKAM_EXPORT MetaEngine
58     {
59     
60     public:
61     
62         /**


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp2OAl-2Fauo86CB28HCT0-2BnD-2F6eFMYt863B1-2B0FLvU5y-2FRWSl8rMA4vGwCkGPp0f1hg-3DAR1m_IpEMwFcbl-2BY9RHaL2m6a3nuAxB4hfm4MTniX0gHjADUwRcBRxVo9Rb43-2B5T4QqQ9XoHl7eo0E5wwv7hd-2BmVKuWOGfAQgm8IL4NzlY8G8YtaHXignaIOwCqt4WkGhtj0eQ6Ev8JRtmwU5E-2Byc7jgl-2BQq1SqkLvU7U06k25q-2FJWIzL5-2B4-2BrA-2Byjx3LSvSEYJmYdbEqalQTjKJUAFF2yTFkkA-3D-3D