New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

4 new defect(s) introduced to digiKam found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1470386:  Uninitialized members  (UNINIT_CTOR)
/mnt/devel/GIT/7.x/core/tests/dimg/dimgabstracthistorytest.cpp: 55 in DImgAbstractHistoryTest::DImgAbstractHistoryTest(QObject *)()


________________________________________________________________________________________________________
*** CID 1470386:  Uninitialized members  (UNINIT_CTOR)
/mnt/devel/GIT/7.x/core/tests/dimg/dimgabstracthistorytest.cpp: 55 in DImgAbstractHistoryTest::DImgAbstractHistoryTest(QObject *)()
49     #include "imageiface.h"
50     #include "iofilesettings.h"
51     
52     DImgAbstractHistoryTest::DImgAbstractHistoryTest(QObject* const parent)
53         : QObject(parent)
54     {
>>>     CID 1470386:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_im" is not initialized in this constructor nor in any functions that it calls.
55     }
56     
57     QString DImgAbstractHistoryTest::imagePath()
58     {
59         // NOTE: We will use same data dir than album model tests.
60         return QFINDTESTDATA("../albummodel/data/");

** CID 1470385:  Uninitialized members  (UNINIT_CTOR)
/mnt/devel/GIT/7.x/core/dplugins/generic/webservices/mediawiki/backend/mediawiki_image.cpp: 40 in MediaWiki::Image::Private::Private()()


________________________________________________________________________________________________________
*** CID 1470385:  Uninitialized members  (UNINIT_CTOR)
/mnt/devel/GIT/7.x/core/dplugins/generic/webservices/mediawiki/backend/mediawiki_image.cpp: 40 in MediaWiki::Image::Private::Private()()
34     class Q_DECL_HIDDEN Image::Private
35     {
36     public:
37     
38         Private()
39         {
>>>     CID 1470385:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "namespaceId" is not initialized in this constructor nor in any functions that it calls.
40         }
41     
42         qint64  namespaceId;
43         QString title;
44     };
45     

** CID 1470384:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1470384:  Null pointer dereferences  (FORWARD_NULL)
/mnt/devel/GIT/7.x/core/utilities/facemanagement/workers/trainerworker.cpp: 52 in Digikam::MapListTrainingDataProvider::newImages(const Digikam::Identity &)()
46     
47         ImageListProvider* newImages(const Identity& identity) override
48         {
49             if (imagesToTrain.contains(identity.id()))
50             {
51                 QListImageListProvider* const provider = imagesToTrain.value(identity.id());
>>>     CID 1470384:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "provider" to "reset", which dereferences it.
52                 provider->reset();
53     
54                 return provider;
55             }
56     
57             return ∅

** CID 1470383:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/dplugins/generic/webservices/mediawiki/backend/mediawiki_imageinfo.h: 41 in ()


________________________________________________________________________________________________________
*** CID 1470383:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/mnt/devel/GIT/7.x/core/dplugins/generic/webservices/mediawiki/backend/mediawiki_imageinfo.h: 41 in ()
35     namespace MediaWiki
36     {
37     
38     /**
39      * @brief An image info.
40      */
>>>     CID 1470383:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "MediaWiki::Imageinfo" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
41     class Imageinfo
42     {
43     public:
44     
45         /**
46          * @brief Constructs an image info.


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp2OAl-2Fauo86CB28HCT0-2BnD-2F6eFMYt863B1-2B0FLvU5y-2FRWSl8rMA4vGwCkGPp0f1hg-3DtSuZ_IpEMwFcbl-2BY9RHaL2m6a3nuAxB4hfm4MTniX0gHjADVrGoBZbWhmLBgJtXGgYcznGb00lWXQuVp27MU4PH1qeVSwW5ptXkT5FeJQ3OM69sT9Epvf67r-2F60Pz74OtW2miUx-2FczZjKaxSeJkVacECM8-2BGV9FZVD18w2p-2BfjghVw1kxkXrAPvvqnSugggELQCLkYw8Fzv-2B08eMNZroLO-2BkMNTOu3lFsaa2M8NvHHsRTOTE-3D