Spelling error in Signal name

Maik Qualmann metzpinguin at gmail.com
Thu Jun 25 21:59:45 BST 2020


Hi Kartik,

The typing error has now been corrected in master and your branch.

Maik

Am Donnerstag, 25. Juni 2020, 08:49:22 CEST schrieb Kartik Ramesh:
> Hi Maik,
> 
> I don't think it has been corrected in master yet :
> https://invent.kde.org/graphics/digikam/-/blob/master/core/app/views/sidebar
> /sidebarwidget.h#L109 I can fix this in my branch if needed, and it would be
> included in master when the branches get merged.
> 
> Kartik
> 
> On Thu, Jun 25, 2020 at 11:36 AM Maik Qualmann <metzpinguin at gmail.com>
> 
> wrote:
> > Hi Kartik,
> > 
> > Yes, that's a typo. It should already be corrected in git/master.
> > 
> > Maik
> > 
> > Am Donnerstag, 25. Juni 2020, 07:47:04 CEST schrieb Kartik Ramesh:
> > > Hello all,
> > > 
> > > The left sidebar widgets are provided with a notification widget, which
> > > allows display of slide-in timed notifications. This signal is currently
> > > named signalNofificationError
> > > <
> > 
> > https://invent.kde.org/graphics/digikam/-/blob/gsoc20-facesengine-workflow
> > /
> > 
> > > core/app/views/sidebar/sidebarwidget.h#L109>, is this a misspell? There
> > > aren't many places that emit this signal, so correcting it everywhere to
> > > signalNotificationError wouldn't be much difficult. Should I correct
> > 
> > this?
> > 
> > > Kartik






More information about the Digikam-devel mailing list