New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

4 new defect(s) introduced to digiKam found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1457605:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Documents/GIT/7.x/core/dplugins/generic/import/dscanner/dscannerplugin.cpp: 140 in DigikamGenericDScannerPlugin::DigitalScannerPlugin::slotDigitalScanner()()


________________________________________________________________________________________________________
*** CID 1457605:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Documents/GIT/7.x/core/dplugins/generic/import/dscanner/dscannerplugin.cpp: 140 in DigikamGenericDScannerPlugin::DigitalScannerPlugin::slotDigitalScanner()()
134                 return;
135             }
136     
137             if (!m_saneWidget->openDevice(dev))
138             {
139                 // could not open a scanner
>>>     CID 1457605:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "warning" without checking return value (as is done elsewhere 39 out of 48 times).
140                 QMessageBox::warning(nullptr, qApp->applicationName(), i18n("Cannot open scanner device."));
141                 return;
142             }
143     
144             DInfoInterface* const iface = infoIface(sender());
145             ScanDialog* const dlg       = new ScanDialog(m_saneWidget);

** CID 1457604:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Documents/GIT/7.x/core/utilities/setup/collections/setupcollectionview.cpp: 1164 in Digikam::SetupCollectionModel::askForNewCollectionPath(int, QString *, QString *)()


________________________________________________________________________________________________________
*** CID 1457604:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Documents/GIT/7.x/core/utilities/setup/collections/setupcollectionview.cpp: 1164 in Digikam::SetupCollectionModel::askForNewCollectionPath(int, QString *, QString *)()
1158             case CollectionManager::LocationHasProblems:
1159                 iconName = QLatin1String("dialog-information");
1160                 break;
1161     
1162             case CollectionManager::LocationNotAllowed:
1163             case CollectionManager::LocationInvalidCheck:
>>>     CID 1457604:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "warning" without checking return value (as is done elsewhere 39 out of 48 times).
1164                 QMessageBox::warning(m_dialogParentWidget, i18n("Problem Adding Collection"), messageFromManager);
1165                 // fail
1166                 return false;
1167         }
1168     
1169         // Create a dialog that displays volume information and allows to change the name of the collection

** CID 1457603:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Documents/GIT/7.x/core/dplugins/generic/tools/mediaserver/dmediaserverdlg.cpp: 337 in DigikamGenericMediaServerPlugin::DMediaServerDlg::startMediaServer()()


________________________________________________________________________________________________________
*** CID 1457603:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Documents/GIT/7.x/core/dplugins/generic/tools/mediaserver/dmediaserverdlg.cpp: 337 in DigikamGenericMediaServerPlugin::DMediaServerDlg::startMediaServer()()
331     
332         if (!setMediaServerContents())
333             return;
334     
335         if (!d->mngr->startMediaServer())
336         {
>>>     CID 1457603:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "warning" without checking return value (as is done elsewhere 39 out of 48 times).
337             QMessageBox::warning(this, i18n("Starting Media Server"),
338                                  i18n("An error occurs while to start Media Server..."));
339         }
340         else
341         {
342             d->mngr->mediaServerNotification(true);

** CID 1457602:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Documents/GIT/7.x/core/dplugins/generic/tools/printcreator/wizard/advprintphotopage.cpp: 1047 in DigikamGenericPrintCreatorPlugin::AdvPrintPhotoPage::slotListPhotoSizesSelected()()


________________________________________________________________________________________________________
*** CID 1457602:  Error handling issues  (CHECKED_RETURN)
/home/gilles/Documents/GIT/7.x/core/dplugins/generic/tools/printcreator/wizard/advprintphotopage.cpp: 1047 in DigikamGenericPrintCreatorPlugin::AdvPrintPhotoPage::slotListPhotoSizesSelected()()
1041     
1042         // reset preview page number
1043         d->settings->currentPreviewPage = 0;
1044     
1045         if (!s)
1046         {
>>>     CID 1457602:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "warning" without checking return value (as is done elsewhere 39 out of 48 times).
1047             QMessageBox::warning(this, i18n("Custom layout"),
1048                                  i18n("The selected custom photo size can "
1049                                       "not be applied to the paper size."));
1050     
1051             // change position to top
1052             d->photoUi->ListPhotoSizes->setCurrentRow(0);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZIlZa20oQ0xtvekoaSXYBwveaZrocF7HKhDAyMb-2Biah-2FnlVHKEoHYKtgojWoi52Ac-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTC-2BkZefb2Jq600aFgyrx3ZuBI-2BiTpWhQiYrct6t4BGiNfLsBJay0YEs-2B1WXOox6-2FwW4eLRTrwLq2oz0ry5kRC5TM5Zd860MueXVnpnfu0723EH8CA1HbKuc9ovJ6C9B4VnWWbp9U2GXSx6TzOaL791BSySIGVsaEJBdGRe1KPMc5iuzooEZkfz9pFnWk9cuOGfWYmRpLC4j-2BYDFsXIf9PIk