New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

5 new defect(s) introduced to digiKam found with Coverity Scan.
102 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1466261:  Null pointer dereferences  (FORWARD_NULL)
/mnt/devel/GIT/DK.nghia/core/libs/facesengine/recognition/facialrecognition_wrapper_identity.cpp: 198 in Digikam::FacialRecognitionWrapper::addIdentity(const QMap<QString, QString> &)()


________________________________________________________________________________________________________
*** CID 1466261:  Null pointer dereferences  (FORWARD_NULL)
/mnt/devel/GIT/DK.nghia/core/libs/facesengine/recognition/facialrecognition_wrapper_identity.cpp: 198 in Digikam::FacialRecognitionWrapper::addIdentity(const QMap<QString, QString> &)()
192     }
193     
194     Identity FacialRecognitionWrapper::addIdentity(const QMap<QString, QString>& attributes)
195     {
196         if (!d || !d->dbAvailable)
197         {
>>>     CID 1466261:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "this->d".
198             qDebug() << "Faces engine is available" << d->dbAvailable;
199             return Identity();
200         }
201     
202         QMutexLocker lock(&d->mutex);
203     

** CID 1466260:  Uninitialized members  (UNINIT_CTOR)
/mnt/devel/GIT/DK.nghia/core/libs/facesengine/facedb/facedb_dnn_spatial.cpp: 51 in Digikam::FaceDb::DataNode::DataNode()()


________________________________________________________________________________________________________
*** CID 1466260:  Uninitialized members  (UNINIT_CTOR)
/mnt/devel/GIT/DK.nghia/core/libs/facesengine/facedb/facedb_dnn_spatial.cpp: 51 in Digikam::FaceDb::DataNode::DataNode()()
45     
46         explicit DataNode()
47             : nodeID(0),
48               label(0),
49               splitAxis(0)
50         {
>>>     CID 1466260:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "right" is not initialized in this constructor nor in any functions that it calls.
51         }
52     
53         bool isNull() const
54         {
55             return (nodeID == 0);
56         }

** CID 1466259:  Error handling issues  (CHECKED_RETURN)
/mnt/devel/GIT/DK.nghia/core/libs/widgets/mainview/dactivelabel.cpp: 49 in Digikam::DActiveLabel::DActiveLabel(const QUrl &, const QString &, QWidget *)()


________________________________________________________________________________________________________
*** CID 1466259:  Error handling issues  (CHECKED_RETURN)
/mnt/devel/GIT/DK.nghia/core/libs/widgets/mainview/dactivelabel.cpp: 49 in Digikam::DActiveLabel::DActiveLabel(const QUrl &, const QString &, QWidget *)()
43         setSizePolicy(QSizePolicy(QSizePolicy::Minimum, QSizePolicy::Minimum));
44     
45         QImage img;
46     
47         if (!imgPath.isEmpty())
48         {
>>>     CID 1466259:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "load" without checking return value (as is done elsewhere 4 out of 5 times).
49             img.load(imgPath);
50         }
51     
52         updateData(url, img);
53     }
54     

** CID 1466258:  Incorrect expression  (USELESS_CALL)


________________________________________________________________________________________________________
*** CID 1466258:  Incorrect expression  (USELESS_CALL)
/usr/lib64/qt5/include/QtCore/qvector.h: 823 in QVector<Digikam::DNNFaceExtractor *>::erase(QTypedArrayData<Digikam::DNNFaceExtractor *>::iterator, QTypedArrayData<Digikam::DNNFaceExtractor *>::iterator)()
817             aend = abegin + itemsToErase;
818             if (!QTypeInfoQuery<T>::isRelocatable) {
819                 iterator moveBegin = abegin + itemsToErase;
820                 iterator moveEnd = d->end();
821                 while (moveBegin != moveEnd) {
822                     if (QTypeInfo<T>::isComplex)
>>>     CID 1466258:  Incorrect expression  (USELESS_CALL)
>>>     Calling "abegin.operator DNNFaceExtractor **()" is only useful for its return value, which is ignored.
823                         static_cast<T *>(abegin)->~T();
824                     new (abegin++) T(*moveBegin++);
825                 }
826                 if (abegin < d->end()) {
827                     // destroy rest of instances
828                     destruct(abegin, d->end());

** CID 1466257:  Uninitialized members  (UNINIT_CTOR)
/mnt/devel/GIT/DK.nghia/core/libs/facesengine/recognition/opencv-dnn/dnnfaceextractor.cpp: 51 in Digikam::DNNFaceExtractor::Private::Private()()


________________________________________________________________________________________________________
*** CID 1466257:  Uninitialized members  (UNINIT_CTOR)
/mnt/devel/GIT/DK.nghia/core/libs/facesengine/recognition/opencv-dnn/dnnfaceextractor.cpp: 51 in Digikam::DNNFaceExtractor::Private::Private()()
45     {
46     public:
47     
48         Private()
49             : preprocessor(nullptr)
50         {
>>>     CID 1466257:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "scaleFactor" is not initialized in this constructor nor in any functions that it calls.
51         }
52     
53         ~Private()
54         {
55             delete preprocessor;
56         }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yp2OAl-2Fauo86CB28HCT0-2BnD-2F6eFMYt863B1-2B0FLvU5y-2FRWSl8rMA4vGwCkGPp0f1hg-3Dk9nF_IpEMwFcbl-2BY9RHaL2m6a3nuAxB4hfm4MTniX0gHjADV7ma442oDfcgjiP9fBaD3Ku7l-2BjlAmOb6vIZAeNTWDSiBdj3NF9zkQBFdkx-2Fhlfdqp5PiA-2FS2XhmoYI0TK9ccjjEz9Ly0sCDzhLGIS8BWZvASyTGOUg71sy9TST1-2BSKLwjxhV0tRb6l4t7e-2Flmk-2F-2BS4o-2F-2FhTVossn-2BBYKsNjji5o4kKrivwWNl-2BHU3jlxsGxA-3D