Facebook webservice: content access denied
Maik Qualmann
metzpinguin at gmail.com
Sun Jun 17 18:16:45 BST 2018
Hi Thanh,
I have already looked very deeply and can find no error in the implementation.
At the moment I do not know why access is denied. I stay tuned.
Maik
Am Sonntag, 17. Juni 2018, 16:49:49 CEST schrieb Gilles Caulier:
> yes it is.
>
> There is also this one :
>
>
> 1. Check for spelling errors [spelling]...*OOPS! 2 issues found!*
> - /core/utilities/assistants/webservices/facebook/fbtalker.cpp
>
> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assis
> tants/webservices/facebook/fbtalker.cpp>:
> /core/utilities/assistants/webservices/facebook/fbtalker.cpp -
> /core/utilities/assistants/webservices/facebook/fbtalker.cpp
> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assis
> tants/webservices/facebook/fbtalker.cpp>: line# 101
>
> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/assis
> tants/webservices/facebook/fbtalker.cpp#0101>[[neccessary]] (1)
>
> Spelling errors in comments and strings should be fixed as they may show
> up later in API documentation, handbooks, etc. Misspelled strings make
> the translator's job harder. Please use US English.
> 2.
>
>
> Gilles
>
> 2018-06-17 15:33 GMT+02:00 Thanh Trung Dinh <dinhthanhtrung1996 at gmail.com>:
> > So for clang and cppcheck I didn't see problems that really matter in my
> > part.
> >
> > For krazy, I fixed those by changing them to QLatin1Char Is it correct?
> >
> > Thanh.
> >
> > On Sun, Jun 17, 2018 at 3:06 PM, Gilles Caulier <caulier.gilles at gmail.com>
> >
> > wrote:
> >> Look the krazy report here :
> >>
> >> https://www.digikam.org/reports/krazy/gsoc18-exporttools-o2/
> >>
> >> This part is for you :
> >>
> >> Check single-char QString operations for efficiency
> >> [doublequote_chars]...*OOPS! 14 issues found!*
> >>
> >> - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp>: => data += "{";
> >> - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp>: => data += "{";
> >> - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp>: => data += "}";
> >> - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp>: => data += "}";
> >> - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp>: => data += ",";
> >> - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp>: => data += "]";
> >> - /core/utilities/assistants/webservices/google/gphoto/gptalker.cpp
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp>: line# 678
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp#0678> ,695
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp#0695> ,701
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp#0701> ,702
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp#0702> ,705
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp#0705> ,710
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/google/gphoto/gptalker.cpp#0710>>>
> >> (6)
> >>
> >> - /core/utilities/assistants/webservices/smugmug/smugtalker.cpp
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/smugmug/smugtalker.cpp>: => QStringList words =
> >> n.split(" ");
> >> - /core/utilities/assistants/webservices/smugmug/smugtalker.cpp
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/smugmug/smugtalker.cpp>: split issues line# 324
> >> <http://lxr.kde.org/source/extragear/graphics/digikam//core/utilities/
> >> assistants/webservices/smugmug/smugtalker.cpp#0324>>>
> >> (1)
> >>
> >> Adding single characters to a QString is faster if the characters are
> >> QChars and not QStrings. For example: QString path = oldpath + "/" + base
> >> is better written as QString path = oldpath + '/' + base. Same holds for
> >> arguments to QString::startsWith(), QString::endsWith(),
> >> QString::remove(),
> >> QString::split(). Use QString::remove() instead of
> >> QString::replace(foo,"")
> >> Gilles
> >
> > --
> > Mr. Thanh-Trung Dinh
> > Université de Technologie de Compiègne (UTC) - France
> > Tel: +33 7 53 68 20 29
More information about the Digikam-devel
mailing list