New Defects reported by Coverity Scan for digiKam
scan-admin at coverity.com
scan-admin at coverity.com
Thu May 25 19:03:11 BST 2017
Hi,
Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.
3 new defect(s) introduced to digiKam found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1409879: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/usr/lib64/qt5/include/QtAV/Frame.h: 33 in ()
________________________________________________________________________________________________________
*** CID 1409879: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/usr/lib64/qt5/include/QtAV/Frame.h: 33 in ()
27 #include <QtCore/QSharedData>
28
29 // TODO: fromAVFrame() asAVFrame()?
30 namespace QtAV {
31
32 class FramePrivate;
>>> CID 1409879: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "QtAV::Frame" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
33 class Q_AV_EXPORT Frame
34 {
35 Q_DECLARE_PRIVATE(Frame)
36 public:
37 Frame(const Frame& other);
38 virtual ~Frame() = 0;
** CID 1409878: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/usr/lib64/qt5/include/QtAV/VideoFrame.h: 33 in ()
________________________________________________________________________________________________________
*** CID 1409878: Low impact quality (MISSING_MOVE_ASSIGNMENT)
/usr/lib64/qt5/include/QtAV/VideoFrame.h: 33 in ()
27 #include <QtCore/QSize>
28 /// TODO: fromAVFrame(const AVFrame* f);
29 namespace QtAV {
30
31 /// metadata: pallete for pal8
32 class VideoFramePrivate;
>>> CID 1409878: Low impact quality (MISSING_MOVE_ASSIGNMENT)
>>> Class "QtAV::VideoFrame" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
33 class Q_AV_EXPORT VideoFrame : public Frame
34 {
35 Q_DECLARE_PRIVATE(VideoFrame)
36 public:
37 /*!
38 * \brief fromGPU
** CID 1409877: Null pointer dereferences (FORWARD_NULL)
/home/gilles/Devel/5.x/core/utilities/kdesupport/kipi/kipiimagecollection.cpp: 94 in Digikam::KipiImageCollection::name()()
________________________________________________________________________________________________________
*** CID 1409877: Null pointer dereferences (FORWARD_NULL)
/home/gilles/Devel/5.x/core/utilities/kdesupport/kipi/kipiimagecollection.cpp: 94 in Digikam::KipiImageCollection::name()()
88 QString KipiImageCollection::name()
89 {
90 if (d->album->type() == Album::TAG)
91 {
92 return i18n("Tag: %1", d->album->title());
93 }
>>> CID 1409877: Null pointer dereferences (FORWARD_NULL)
>>> Dynamic cast to pointer "dynamic_cast <Digikam::SAlbum *>(this->d->album)" can return "NULL".
94 else if ((d->album->type() == Album::SEARCH) && dynamic_cast<SAlbum*>(d->album)->isDuplicatesSearch())
95 {
96 ImageInfo imageInfo(d->album->title().toLongLong());
97 return i18n("Duplicates of %1", imageInfo.name());
98 }
99 else
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZIlZa20oQ0xtvekoaSXYBwgZYh7yqZ4T857KvBwnvzEg-3D-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTBO8EX2bn00eU7aCVjRQqgSrHL2LV9xmyxVpTu-2BhulpFrumI9op6vEZQbxWsU-2BFzizj9hpjghfHf7YN3-2FHD1KUjoKSYWdbBzBD4yWnRe5hT0tA-2FLKTRBGKiJl-2FrwlK14e-2FdEyW-2B5XtpY-2Bv385sjtPcLW28rWG3c-2F1En0sRLkTtBqddhb1uHM7oiJ9-2FlB4XiDU4-3D
To manage Coverity Scan email notifications for "digikam-devel at kde.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4g-2BkTwi3e7HlDkvMAkUMj2-2FFhZ2O-2BELTTy-2Fl1ea1gxKqmntchu8-2BeAOkExRtki0102MqL9th0o1rOws5-2F-2FQDFdjkpeJaB-2FdUMxPk-2B7ZQUGV0-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTBO8EX2bn00eU7aCVjRQqgS0muMvGUi7vmfUhy5MsTJF3esr-2BzgIs4Nz4TkYbrYQ3hBLxrV-2BGeAeAaVXLC4xYVJm4nePp-2FB81av4rxPkutOHGXWyBXELmaG-2FuYvcXIT37lEcFZH9tto1lim9V-2FR0MCQ5T4ty-2FvPT-2BQiFhd39mn0gXKRzW-2FKpfJZa3fcIkyiKDk-3D
More information about the Digikam-devel
mailing list