[digikam] [Bug 273751] BQM Watermark tool : Add support for svg and variable parts

[bugzilla_noreply at kde.org]

https://bugs.kde.org/show_bug.cgi?id=273751

--- Comment #5 from caulier.gilles at gmail.com ---
Ahmed,

I take a look into your patch, and i'm not agree with it.

1/ You patch DImg to handle SVG, but it's wrong. The type-mime enum from DIMg
is to list supported file format with native decoder in DK core. SVG is support
through QImage. That all.

2/ Your patch in watermark suppose that user know image as SVG. This will never
work to non SVG image. BQM is dedicated to be fully automatic, that all.

3/ Your patch suppose that SVG image will be loaded in BQM through DIMG and
patch XML as well. I think the basis of of this report is to apply a SVG over a
raster image as a raster image (as users generate logo in Inkscape and
watermark image with it). So loading SVG through QImage, render it as RGB and
apply it over image is enough. The only problem is to support 16 bits color
depth. So to solve it : load with DImg QImage loader, convert to 16 bits, apply
to image.

4/ In other words, we don't support vector graphics images as well. This is not
the goal of digiKam. We are raster graphic tools, that all. Patching XML
contents in BQM is a wrong idea, else we will need to support it in editor too,
and we don't want to make Inkscape here...

Please re-visit your patch. The solution here will be more simpler to achieve.

Gilles Caulier

-- 
You are receiving this mail because:
You are the assignee for the bug.