[digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

[bugzilla_noreply at kde.org]

https://bugs.kde.org/show_bug.cgi?id=361047

--- Comment #66 from caulier.gilles at gmail.com ---
Hi Simon,

I agree that no performance issue is visible with grouped frame pixmap. The
cache is well used...

But look well in patch :

     if (!d->ratingRect.isNull())
     {
-        drawRating(p, index, d->ratingRect, info.rating(), isSelected);
+        int backgroundtype = 0;
+        if(isSelected)
+        {
+            backgroundtype = 1;
+        }
+        else if(isGroupExpanded)
+        {
+            backgroundtype = 2;
+        }
+
+        drawRating(p, index, d->ratingRect, info.rating(), backgroundtype);
     }

Why this kind of code for rating widget ? Why hard coded values in source code
?

As i said previously, there is also a layout problem with icon-view item
contents. Go to Setup dialog, and turn on HiDPI compatible thumbnail size
(<=512 px).

Now, turn on all icon-view item properties to be visible, and play with
thumbnails size slider from status bar. Look the result, for ex, with GPS
location indicator. The layout is broken...

Gilles

-- 
You are receiving this mail because:
You are the assignee for the bug.