New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

2 new defect(s) introduced to digiKam found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1414840:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/assistants/printcreator/printcreator_src_automoc.dir/moc_advprintwizard_UKLZCD7NOQMJKW.cpp: 85 in Digikam::AdvPrintWizard::qt_metacall(QMetaObject::Call, int, void **)()


________________________________________________________________________________________________________
*** CID 1414840:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/assistants/printcreator/printcreator_src_automoc.dir/moc_advprintwizard_UKLZCD7NOQMJKW.cpp: 85 in Digikam::AdvPrintWizard::qt_metacall(QMetaObject::Call, int, void **)()
79         return DWizardDlg::qt_metacast(_clname);
80     }
81     
82     int Digikam::AdvPrintWizard::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83     {
84         _id = DWizardDlg::qt_metacall(_c, _id, _a);
>>>     CID 1414840:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85         if (_id < 0)
86             return _id;
87         return _id;
88     }

** CID 1414839:  Uninitialized members  (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/manager/advprintsettings.cpp: 53 in Digikam::AdvPrintSettings::AdvPrintSettings()()


________________________________________________________________________________________________________
*** CID 1414839:  Uninitialized members  (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/assistants/printcreator/manager/advprintsettings.cpp: 53 in Digikam::AdvPrintSettings::AdvPrintSettings()()
47         captions           = 0;
48         captionColor       = QColor(Qt::yellow);
49         captionFont        = QFont(QLatin1String("Sans Serif"));
50         captionSize        = 4;
51         outputLayouts      = 0;
52         outputPrinter      = 0;
>>>     CID 1414839:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "openInFileBrowser" is not initialized in this constructor nor in any functions that it calls.
53     }
54     
55     AdvPrintSettings::~AdvPrintSettings()
56     {
57         for (int i = 0 ; i < photos.count() ; ++i)
58         {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZIlZa20oQ0xtvekoaSXYBwgZYh7yqZ4T857KvBwnvzEg-3D-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTAy8ZKLgV-2Foprn5hJyKnmyxF8qWvcERIVhFkUT-2BIrmnBFmHyAi5GFx63dOaTWkH9UxhIC4LzAhd-2F7zLDae1SX7flPFpY4B9MSETDoJh7YEqf8d5lS9G5PUh16BZTNMJ7q4rP09zVLgJ7Ph5zMSXhpE3tKCl6Pjj7TlX0BUWGB5NvlvmIQqsQAXn7C1JJzkQ0qE-3D

To manage Coverity Scan email notifications for "digikam-devel at kde.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4g-2BkTwi3e7HlDkvMAkUMj2-2FFhZ2O-2BELTTy-2Fl1ea1gxKqmntchu8-2BeAOkExRtki0102MqL9th0o1rOws5-2F-2FQDFdjkpeJaB-2FdUMxPk-2B7ZQUGV0-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTAy8ZKLgV-2Foprn5hJyKnmyxyGZvfBYwzkpVpDrex-2BtLq234OxwJdOJhBjUKIlAI40ha-2BZGFaDqf1T6dMGb4KYZkEE-2Fp7FxZLhfAUC7A-2B7svOQdiLjJNW7pPkNG9bY0z3wFKpecQeOgHhBCs3AUCXewZH5VVc-2BeQhF1PJw8Na3Z-2BKixenBXdlAE199sYeeeTg7k-3D