[digikam] [Bug 328457] BQM Watermark tool : doesn't apply zero margins

[Ahmed Fathi]

https://bugs.kde.org/show_bug.cgi?id=328457

Ahmed Fathi <ahmed.fathi.abdelmageed at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ahmed.fathi.abdelmageed at gma
                   |                            |il.com

--- Comment #1 from Ahmed Fathi <ahmed.fathi.abdelmageed at gmail.com> ---
Created attachment 103576
  --> https://bugs.kde.org/attachment.cgi?id=103576&action=edit
a patch to solve the margin problem

HI , I solved this "bug" and here is the batch .
In the following post I will send screenshots

There were two problems :-

First in the function calls : watermarkRect.moveTopRight() ,
watermarkRect.moveBottomLeft(), watermarkRect.moveBottomRight() , We needed to
pass (Width -1 ) and (height -1 ) instead of Width and height.

The second problem was that the watermark photo has a different aspect ration
than the original photo. An option to "Keep Aspect ratio" of the waterMark was
used, so however large the watermark Image was , keeping its aspect ratio will
always leave spaces in the actual image. 
Changing the option from Qt::KeepAspectRatio  to  Qt::IgnoreAspectRatio  will
solve the problem and make the watermark always have the aspect ratio of the
original photo as @mnaugendre requires. but it is not logical to Always ignore
the aspect ratio of the watermark and stretch it to be exactly like the image.
So I added a new checkbox to allow the user to ignore the water mark aspect
ratio If that is what he really needs , which is unchecked by default.

-- 
You are receiving this mail because:
You are the assignee for the bug.