[digikam] [Bug 374225] Add possibility to remove face identities by removing tag and remove person tags but preserving the tags themselves [patch]

[Mario Frank]

https://bugs.kde.org/show_bug.cgi?id=374225

Mario Frank <mario.frank at uni-potsdam.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #103361|0                           |1
        is obsolete|                            |

--- Comment #18 from Mario Frank <mario.frank at uni-potsdam.de> ---
Created attachment 103373
  --> https://bugs.kde.org/attachment.cgi?id=103373&action=edit
New patch for removing face tags

Okay, I had to fix the dialog texts and some other stuff.
Now, the actions are called "Remove Face Tag" and "Remove Face Tags",
respectively.
The dialog for untagging the tagged images after removing the face property has
now Yes and No as options. 
The dialogs now explicitely state which face tags are still connected to some
images and which face tags have subtags that are face tags, too. 
I also set What's this texts but they are not shown which is weird.

Furthermore, in people sidebar, only "Remove Face Tag" and "Remove Face Tags"
can be selected as actions. 
I removed "Delete Tag" and "Delete Tags" since these actions should be located
only in tags sidebar. 
Otherwise, users may be confused about the semantics. And I think we should
keep functionality where it fits best semantically.
Thus, delete tags in tags sidebar and remove faces in people sidebar.

Finally, I sync the tags metadata to the files - only the tags metadata.
I get the image info for the files, load the metadata with metadata hub and use
the function writeTags.
I hope this is an appropriate way.
I tested this functionality with showFoto and it worked.

So,
Please take a look.

-- 
You are receiving this mail because:
You are the assignee for the bug.