[digikam] [Bug 374191] Unusable context menu entries in tags and people view

Mario Frank bugzilla_noreply at kde.org
Fri Jan 6 13:23:01 GMT 2017


--- Comment #27 from Mario Frank <mario.frank at uni-potsdam.de> ---
(In reply to Simon from comment #26)
> Created attachment 103228 [details]
> Patch for triggering duplicates search for multiple tags with context menu
> and refactor.
> I took the sections of https://bugs.kde.org/attachment.cgi?id=103203 that
> are relevant to this bug and extended the changes. My changes just extend
> the refactoring, they don't introduce any change in behaviour:
>  - Use the new function selectedTagAlbums instead of selctedTags where
> appropriate.
>  - Remove any remaining usages of ...FindDuplicatesInAlbum(Album*...
> (albumselectiontreeview), such that everything related to duplicates sends
> either PAlbums or TAlbums.
>  - Rename methods: s/Item/Album/. Items is usually used in the context of
> indexes and other functions (currentAlbum) also use this terminology.
> I played around with it and in album, tree and people view it worked as
> expected. So from my side this is good to merge.
> Regarding the similarity search of faces: I think the functionality as it is
> currently is fine. Similarity search only on a face area would be more or
> less the same as the recognize faces function, wouldn't it?
> I absolutely agree that the people interface is still lacking in terms of
> usability. It would be great having a way to separate confirmed from
> unconfirmed faces. Then searching for similar face would work like:
> recognize faces -> select a face tag -> only show unconfirmed faces

Hey Simon,

thanks for the factoring. I will test the two patches and if everything works
as expected give you a confirmation. Can you, too test the
duplicates/sketch/drop/fuzzy search and look whether it conforms to the
description in 
https://bugs.kde.org/show_bug.cgi?id=320666#c22 ?

You are receiving this mail because:
You are the assignee for the bug.

More information about the Digikam-devel mailing list