[digikam] [Bug 374191] Unusable context menu entries in tags view

Mario Frank bugzilla_noreply at kde.org
Mon Jan 2 18:52:01 GMT 2017


--- Comment #18 from Mario Frank <mario.frank at uni-potsdam.de> ---
(In reply to Simon from comment #17)
> (In reply to Mario Frank from comment #16)
> > [...]
> > 
> > Hi Simon,
> > 
> > I am not completely happy with this solution.
> > But the AlbumTreeView from which the TagFolderView is derived only provides
> > me access to the list of selected tags as list of Album pointers. Using
> > overloaded methods is also my preferred way. But to do this, I would either
> > have to transform the list of Album pointers to a list of TAlbum pointers
> > which is an unnecessary complexity. Or I will have to adopt the
> > AlbumTreeView for this. 
> > The latter is the way to go, I think.
> I agree. Even from the naming it is weird that in TagTreeView the
> selectedAlbum and albumForIndex methods return TAlbum, while selectedTags
> returns Album. So changing this seems natural. And selectedTags isn't used
> so widely, so not much adaption should be necessary.

I already adopted the code and found some other effectless context menu entry.
In people-sidebar, the find duplicates contect menu item does not have any
effect. I wired the context menu to the same functionality as for tags, i.e.
selected people tags are set as tags in the find duplicates view.

This should be the expected behaviour, right?

You are receiving this mail because:
You are the assignee for the bug.

More information about the Digikam-devel mailing list