New Defects reported by Coverity Scan for digiKam

scan-admin at coverity.com scan-admin at coverity.com
Fri Feb 3 06:25:47 GMT 2017


Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

80 new defect(s) introduced to digiKam found with Coverity Scan.
15 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 20 of 80 defect(s)


** CID 1399966:  Uninitialized members  (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/dtrash/dtrashiteminfo.cpp: 34 in Digikam::DTrashItemInfo::DTrashItemInfo()()


________________________________________________________________________________________________________
*** CID 1399966:  Uninitialized members  (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/dtrash/dtrashiteminfo.cpp: 34 in Digikam::DTrashItemInfo::DTrashItemInfo()()
28     #include <QDebug>
29     
30     namespace Digikam {
31     
32     DTrashItemInfo::DTrashItemInfo()
33     {
>>>     CID 1399966:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "imageId" is not initialized in this constructor nor in any functions that it calls.
34     }
35     
36     bool DTrashItemInfo::isNull() const
37     {
38         return trashPath.isEmpty()              &&
39                jsonFilePath.isEmpty()           &&

** CID 1399965:  Uninitialized variables  (UNINIT)
/home/gilles/Devel/5.x/core/libs/rawengine/libraw/internal/dcraw_common.cpp: 1570 in LibRaw::phase_one_flat_field(int, int)()


________________________________________________________________________________________________________
*** CID 1399965:  Uninitialized variables  (UNINIT)
/home/gilles/Devel/5.x/core/libs/rawengine/libraw/internal/dcraw_common.cpp: 1570 in LibRaw::phase_one_flat_field(int, int)()
1564     	cend = head[0] + x*head[4];
1565     	for (col = cend-head[4];
1566     	     col < raw_width &&
1567     	     col < cend && col < head[0]+head[2]-head[4]; col++) {
1568     	  c = nc > 2 ? FC(row-top_margin,col-left_margin) : 0;
1569     	  if (!(c & 1)) {
>>>     CID 1399965:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "mult[c]".
1570     	    c = RAW(row,col) * mult[c];
1571     	    RAW(row,col) = LIM(c,0,65535);
1572     	  }
1573     	  for (c=0; c < nc; c+=2)
1574     	    mult[c] += mult[c+1];
1575     	}

** CID 1399964:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/libs/dngwriter/extra/dng_sdk/dng_mutex.cpp: 240 in dng_lock_mutex::~dng_lock_mutex()()


________________________________________________________________________________________________________
*** CID 1399964:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/libs/dngwriter/extra/dng_sdk/dng_mutex.cpp: 240 in dng_lock_mutex::~dng_lock_mutex()()
234     		fMutex->Lock ();
235     
236     	}
237     
238     /*****************************************************************************/
239     
>>>     CID 1399964:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "dng_exception" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
240     dng_lock_mutex::~dng_lock_mutex ()
241     	{
242     
243     	if (fMutex)
244     		fMutex->Unlock ();
245     

** CID 1399963:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/libs/dngwriter/extra/dng_sdk/dng_abort_sniffer.cpp: 172 in dng_set_minimum_priority::~dng_set_minimum_priority()()


________________________________________________________________________________________________________
*** CID 1399963:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/libs/dngwriter/extra/dng_sdk/dng_abort_sniffer.cpp: 172 in dng_set_minimum_priority::~dng_set_minimum_priority()()
166     	#endif
167     
168     	}
169     
170     /*****************************************************************************/
171     
>>>     CID 1399963:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "dng_exception" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
172     dng_set_minimum_priority::~dng_set_minimum_priority ()
173     	{
174     
175     	#if qDNGThreadSafe
176     
177     	gPriorityManager.Decrement (fPriority);

** CID 1399962:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/libs/dimg/filters/greycstoration/cimg/greycstoration.h: 158 in cimg_library::CImg<float>::GreycstorationThreadManager::~GreycstorationThreadManager()()


________________________________________________________________________________________________________
*** CID 1399962:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/libs/dimg/filters/greycstoration/cimg/greycstoration.h: 158 in cimg_library::CImg<float>::GreycstorationThreadManager::~GreycstorationThreadManager()()
152         GreycstorationThreadManager()
153             : counter(0), stopRequest(false), activeThreads(0),
154               source(0), temporary(0), empty_mask(new CImg<unsigned char>())
155         {
156         }
157     
>>>     CID 1399962:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "cimg_library::CImgIOException" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
158         ~GreycstorationThreadManager()
159         {
160             stop();
161             wait();
162             finish();
163             qDeleteAll(threads);

** CID 1399961:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/libs/dngwriter/extra/xmp_sdk/XMPCore/XMPCore_Impl.hpp: 222 in DngXmpSdk::XMP_AutoMutex::~XMP_AutoMutex()()


________________________________________________________________________________________________________
*** CID 1399961:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/libs/dngwriter/extra/xmp_sdk/XMPCore/XMPCore_Impl.hpp: 222 in DngXmpSdk::XMP_AutoMutex::~XMP_AutoMutex()()
216     extern void XMP_EnterCriticalRegion ( XMP_Mutex & mutex );
217     extern void XMP_ExitCriticalRegion ( XMP_Mutex & mutex );
218     
219     class XMP_AutoMutex {
220     public:
221         XMP_AutoMutex() : mutex(&sXMPCoreLock) { XMP_EnterCriticalRegion ( *mutex ); ReportLock(); };
>>>     CID 1399961:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "DngXmpSdk::XMP_Error" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
222         ~XMP_AutoMutex() { if ( mutex != 0 ) { ReportUnlock(); XMP_ExitCriticalRegion ( *mutex ); mutex = 0; } };
223         void KeepLock() { ReportKeepLock(); mutex = 0; };
224     private:
225         XMP_Mutex * mutex;
226     };
227     

** CID 1399960:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/libs/dngwriter/extra/dng_sdk/dng_mutex.cpp: 263 in dng_unlock_mutex::~dng_unlock_mutex()()


________________________________________________________________________________________________________
*** CID 1399960:  Error handling issues  (UNCAUGHT_EXCEPT)
/home/gilles/Devel/5.x/core/libs/dngwriter/extra/dng_sdk/dng_mutex.cpp: 263 in dng_unlock_mutex::~dng_unlock_mutex()()
257     		fMutex->Unlock ();
258     
259     	}
260     
261     /*****************************************************************************/
262     
>>>     CID 1399960:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "dng_exception" is thrown but the throw list "throw()" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
263     dng_unlock_mutex::~dng_unlock_mutex ()
264     	{
265     
266     	if (fMutex)
267     		fMutex->Lock ();
268     

** CID 1399959:    (TAINTED_SCALAR)


________________________________________________________________________________________________________
*** CID 1399959:    (TAINTED_SCALAR)
/home/gilles/Devel/5.x/core/libs/facesengine/alignment-congealing/funnelreal.cpp: 177 in FacesEngine::FunnelReal::FunnelReal()()
171         if (!QFileInfo(trainingFile).exists())
172         {
173             qCritical(DIGIKAM_FACESENGINE_LOG) << "Training data for Congealing/Funnel not found. Should be at" << trainingFile;
174             return;
175         }
176     
>>>     CID 1399959:    (TAINTED_SCALAR)
>>>     Passing tainted variable "this->d->edgeDescDim" to a tainted sink.
177         d->loadTrainingData(trainingFile);
178     }
179     
180     FunnelReal::~FunnelReal()
181     {
182         delete d;
/home/gilles/Devel/5.x/core/libs/facesengine/alignment-congealing/funnelreal.cpp: 177 in FacesEngine::FunnelReal::FunnelReal()()
171         if (!QFileInfo(trainingFile).exists())
172         {
173             qCritical(DIGIKAM_FACESENGINE_LOG) << "Training data for Congealing/Funnel not found. Should be at" << trainingFile;
174             return;
175         }
176     
>>>     CID 1399959:    (TAINTED_SCALAR)
>>>     Passing tainted variable "this->d->numFeatureClusters" to a tainted sink.
177         d->loadTrainingData(trainingFile);
178     }
179     
180     FunnelReal::~FunnelReal()
181     {
182         delete d;
/home/gilles/Devel/5.x/core/libs/facesengine/alignment-congealing/funnelreal.cpp: 177 in FacesEngine::FunnelReal::FunnelReal()()
171         if (!QFileInfo(trainingFile).exists())
172         {
173             qCritical(DIGIKAM_FACESENGINE_LOG) << "Training data for Congealing/Funnel not found. Should be at" << trainingFile;
174             return;
175         }
176     
>>>     CID 1399959:    (TAINTED_SCALAR)
>>>     Passing tainted variable "this->d->numRandPxls" to a tainted sink.
177         d->loadTrainingData(trainingFile);
178     }
179     
180     FunnelReal::~FunnelReal()
181     {
182         delete d;

** CID 1399958:    (TAINTED_SCALAR)
/home/gilles/Devel/5.x/core/libs/facesengine/alignment-congealing/funnelreal.cpp: 236 in FacesEngine::FunnelReal::Private::loadTrainingData(const QString &)()
/home/gilles/Devel/5.x/core/libs/facesengine/alignment-congealing/funnelreal.cpp: 234 in FacesEngine::FunnelReal::Private::loadTrainingData(const QString &)()
/home/gilles/Devel/5.x/core/libs/facesengine/alignment-congealing/funnelreal.cpp: 247 in FacesEngine::FunnelReal::Private::loadTrainingData(const QString &)()


________________________________________________________________________________________________________
*** CID 1399958:    (TAINTED_SCALAR)
/home/gilles/Devel/5.x/core/libs/facesengine/alignment-congealing/funnelreal.cpp: 236 in FacesEngine::FunnelReal::Private::loadTrainingData(const QString &)()
230             std::vector<float> cRow(edgeDescDim, 0);
231             centroids = std::vector<std::vector<float> >(numFeatureClusters, cRow);
232             sigmaSq   = std::vector<float>(numFeatureClusters);
233     
234             for(int i = 0; i < numFeatureClusters; i++)
235             {
>>>     CID 1399958:    (TAINTED_SCALAR)
>>>     Using tainted variable "this->edgeDescDim" as a loop boundary.
236                 for(int j = 0; j < edgeDescDim; j++)
237                 {
238                     trainingInfo >> centroids[i][j];
239                 }
240     
241                 trainingInfo >> sigmaSq[i];
/home/gilles/Devel/5.x/core/libs/facesengine/alignment-congealing/funnelreal.cpp: 234 in FacesEngine::FunnelReal::Private::loadTrainingData(const QString &)()
228             trainingInfo >> numFeatureClusters >> edgeDescDim;
229     
230             std::vector<float> cRow(edgeDescDim, 0);
231             centroids = std::vector<std::vector<float> >(numFeatureClusters, cRow);
232             sigmaSq   = std::vector<float>(numFeatureClusters);
233     
>>>     CID 1399958:    (TAINTED_SCALAR)
>>>     Using tainted variable "this->numFeatureClusters" as a loop boundary.
234             for(int i = 0; i < numFeatureClusters; i++)
235             {
236                 for(int j = 0; j < edgeDescDim; j++)
237                 {
238                     trainingInfo >> centroids[i][j];
239                 }
/home/gilles/Devel/5.x/core/libs/facesengine/alignment-congealing/funnelreal.cpp: 247 in FacesEngine::FunnelReal::Private::loadTrainingData(const QString &)()
241                 trainingInfo >> sigmaSq[i];
242             }
243     
244             trainingInfo >> numRandPxls;
245             randPxls = std::vector<std::pair<int, int> >(numRandPxls);
246     
>>>     CID 1399958:    (TAINTED_SCALAR)
>>>     Using tainted variable "this->numRandPxls" as a loop boundary.
247             for(int j = 0; j < numRandPxls; j++)
248                 trainingInfo >> randPxls[j].first >> randPxls[j].second;
249     
250             std::vector<float>                dfCol(numFeatureClusters, 0);
251             std::vector<std::vector<float> >  logDistField(numRandPxls, dfCol);
252     

** CID 1399957:  Incorrect expression  (NO_EFFECT)
/home/gilles/Devel/5.x/core/libs/dimg/filters/redeye/redeyecorrectionfilter.cpp: 150 in Digikam::RedEyeCorrectionFilter::filterImage()()


________________________________________________________________________________________________________
*** CID 1399957:  Incorrect expression  (NO_EFFECT)
/home/gilles/Devel/5.x/core/libs/dimg/filters/redeye/redeyecorrectionfilter.cpp: 150 in Digikam::RedEyeCorrectionFilter::filterImage()()
144         if (type == CV_16UC3 || type == CV_16UC4)
145         {
146             gray.convertTo(gray, CV_8UC1, 1 / 255.0);
147         }
148     
149         QList<QRectF> qrectfdets   = d->facedetector.detectFaces(temp);
>>>     CID 1399957:  Incorrect expression  (NO_EFFECT)
>>>     Part "this->d" of statement "(this->d) , (*Digikam::RedEyeCorrectionFilter::Private::sp)" has no effect due to the comma.
150         redeye::ShapePredictor& sp = *(d->sp);
151     
152         if (runningFlag() && (qrectfdets.size() != 0))
153         {
154             std::vector<cv::Rect> dets;
155             QList<QRect> qrectdets = FacesEngine::FaceDetector::toAbsoluteRects(qrectfdets, temp.size());

** CID 1399956:    (MISSING_MOVE_ASSIGNMENT)
/usr/lib64/qt5/include/QtCore/qfuture.h: 53 in ()
/usr/lib64/qt5/include/QtCore/qfuture.h: 53 in ()


________________________________________________________________________________________________________
*** CID 1399956:    (MISSING_MOVE_ASSIGNMENT)
/usr/lib64/qt5/include/QtCore/qfuture.h: 53 in ()
47     template <typename T>
48     class QFutureWatcher;
49     template <>
50     class QFutureWatcher<void>;
51     
52     template <typename T>
>>>     CID 1399956:    (MISSING_MOVE_ASSIGNMENT)
>>>     Class "QFuture<QPair<QUrl, QString> >" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
53     class QFuture
54     {
55     public:
56         QFuture()
57             : d(QFutureInterface<T>::canceledResult())
58         { }
/usr/lib64/qt5/include/QtCore/qfuture.h: 53 in ()
47     template <typename T>
48     class QFutureWatcher;
49     template <>
50     class QFutureWatcher<void>;
51     
52     template <typename T>
>>>     CID 1399956:    (MISSING_MOVE_ASSIGNMENT)
>>>     Class "QFuture<GeoIface::TrackReader::TrackReadResult>" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
53     class QFuture
54     {
55     public:
56         QFuture()
57             : d(QFutureInterface<T>::canceledResult())
58         { }

** CID 1399955:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/usr/include/marble/GeoDataLineString.h: 72 in ()


________________________________________________________________________________________________________
*** CID 1399955:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/usr/include/marble/GeoDataLineString.h: 72 in ()
66             line segments follow great circles.
67     
68         Some convenience methods have been added that allow to calculate the
69         geodesic bounding box or the length of a LineString.
70     */
71     
>>>     CID 1399955:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Marble::GeoDataLineString" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
72     class GEODATA_EXPORT GeoDataLineString : public GeoDataGeometry
73     {
74     
75      public:
76         typedef QVector<GeoDataCoordinates>::Iterator Iterator;
77         typedef QVector<GeoDataCoordinates>::ConstIterator ConstIterator;

** CID 1399954:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/utilities/geolocation/geoiface/tileindex.h: 46 in ()


________________________________________________________________________________________________________
*** CID 1399954:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/utilities/geolocation/geoiface/tileindex.h: 46 in ()
40     #include "geoiface_types.h"
41     #include "digikam_export.h"
42     
43     namespace GeoIface
44     {
45     
>>>     CID 1399954:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "GeoIface::TileIndex" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
46     class DIGIKAM_EXPORT  TileIndex
47     {
48     public:
49     
50         enum Constants
51         {

** CID 1399953:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/utilities/importui/backend/camiteminfo.h: 46 in ()


________________________________________________________________________________________________________
*** CID 1399953:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/utilities/importui/backend/camiteminfo.h: 46 in ()
40     
41     class QDataStream;
42     
43     namespace Digikam
44     {
45     
>>>     CID 1399953:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::CamItemInfo" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
46     class DIGIKAM_EXPORT CamItemInfo
47     {
48     
49     public:
50     
51         enum DownloadStatus

** CID 1399952:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/libs/dimg/filters/lens/lensfunfilter.h: 34 in ()


________________________________________________________________________________________________________
*** CID 1399952:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/libs/dimg/filters/lens/lensfunfilter.h: 34 in ()
28     #include "dimgthreadedfilter.h"
29     #include "digikam_export.h"
30     
31     namespace Digikam
32     {
33     
>>>     CID 1399952:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::LensFunContainer" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
34     class DIGIKAM_EXPORT LensFunContainer
35     {
36     
37     public:
38     
39         LensFunContainer()

** CID 1399951:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/libs/dimg/filters/icc/icctransform.h: 48 in ()


________________________________________________________________________________________________________
*** CID 1399951:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/libs/dimg/filters/icc/icctransform.h: 48 in ()
42     namespace Digikam
43     {
44     
45     class DImgLoaderObserver;
46     class TransformDescription;
47     
>>>     CID 1399951:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::IccTransform" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
48     class DIGIKAM_EXPORT IccTransform
49     {
50     public:
51     
52         enum RenderingIntent
53         {

** CID 1399950:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/extra/libkvkontakte/src/albuminfo.h: 33 in ()


________________________________________________________________________________________________________
*** CID 1399950:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/extra/libkvkontakte/src/albuminfo.h: 33 in ()
27     #include "libkvkontakte_export.h"
28     
29     namespace Vkontakte
30     {
31     
32     // https://u2389337.ct.sendgrid.net/wf/click?upn=fko48F7Cn2o4yRenFKfeOjCn-2BbPA6sOqd-2BwxS-2BBDbRR7NQOd1bIRX6sSjs5rxwho_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTBZA40gFOa5QmgoMGZz82oYMXkPnGazuSYpcSrtTZR2X5ktnfHkk1OUQhVY5X-2B5y7CfgkC0UbzRHBkC5o3UPvLswcqFsErJCv9e4Yg9RhwCGoZ4RFwffuzOS4eeVG6WosEvV4n7l8ctGA-2F1obGEVeDUZR-2BcgeYc0uw1SbFwcHTsfMF2eXdn2W6C7gAhZ0Df8NA-3D
>>>     CID 1399950:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Vkontakte::AlbumInfo" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
33     class LIBKVKONTAKTE_EXPORT AlbumInfo
34     {
35     public:
36         enum
37         {
38             PRIVACY_UNKNOWN = -1,

** CID 1399949:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/utilities/advancedrename/common/parseresults.h: 36 in ()


________________________________________________________________________________________________________
*** CID 1399949:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/utilities/advancedrename/common/parseresults.h: 36 in ()
30     #include <QPair>
31     #include <QString>
32     
33     namespace Digikam
34     {
35     
>>>     CID 1399949:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Digikam::ParseResults" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
36     class ParseResults
37     {
38     public:
39     
40         typedef QPair<int, int>                ResultsKey;
41         typedef QPair<QString, QString>        ResultsValue;

** CID 1399948:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/usr/lib64/qt5/include/QtSql/qsqldatabase.h: 64 in ()


________________________________________________________________________________________________________
*** CID 1399948:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/usr/lib64/qt5/include/QtSql/qsqldatabase.h: 64 in ()
58     class QSqlDriverCreator : public QSqlDriverCreatorBase
59     {
60     public:
61         QSqlDriver *createObject() const Q_DECL_OVERRIDE { return new T; }
62     };
63     
>>>     CID 1399948:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "QSqlDatabase" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
64     class Q_SQL_EXPORT QSqlDatabase
65     {
66     public:
67         QSqlDatabase();
68         QSqlDatabase(const QSqlDatabase &other);
69         ~QSqlDatabase();

** CID 1399947:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/libs/rawengine/drawdecodersettings.h: 46 in ()


________________________________________________________________________________________________________
*** CID 1399947:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/home/gilles/Devel/5.x/core/libs/rawengine/drawdecodersettings.h: 46 in ()
40     
41     #include "digikam_export.h"
42     
43     namespace RawEngine
44     {
45     
>>>     CID 1399947:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "RawEngine::DRawDecoderSettings" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster.
46     class DIGIKAM_EXPORT DRawDecoderSettings
47     {
48     
49     public:
50     
51         /** RAW decoding Interpolation methods


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZIlZa20oQ0xtvekoaSXYBwgZYh7yqZ4T857KvBwnvzEg-3D-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTBZA40gFOa5QmgoMGZz82oY-2FrPUlGsKao6oNGY-2FQMKJVq54xX-2BpPBAgQo2632gwpSZyCp7v22VgjLEbGPLmpV9CrUxcld757hvXQlwA3TJM9jEFVAyThnYSrOl9eoCOI6es0WZ-2B-2B6btPBNwKhkNPF5LaCbc-2F1RuBv3rMbpJFtFW-2FumlI5V067gqyVDAnDwQf2U-3D

To manage Coverity Scan email notifications for "digikam-devel at kde.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4g-2BkTwi3e7HlDkvMAkUMj2-2FFhZ2O-2BELTTy-2Fl1ea1gxKqmntchu8-2BeAOkExRtki0102MqL9th0o1rOws5-2F-2FQDFdjkpeJaB-2FdUMxPk-2B7ZQUGV0-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTBZA40gFOa5QmgoMGZz82oYsEhbmN4I1SHRkwOxQBb6Mgt87tkECe-2B5EieTWW-2FDZerHvGk14iid7H4z08V3udVNbaZ20ir8N9Y4EV8IOWHeCZmm2xN-2FLtU771aKdqeNvKpLu25hnhzv9DiDQyuGz3Np2-2BuFnNcwHAoo-2BNhaGG6X-2FSH-2FINr8AnXzKLQ6F2ZUMdc-3D




More information about the Digikam-devel mailing list