Failing unit tests

[Veaceslav Munteanu]

On Thu, Aug 3, 2017 at 6:50 PM, Maik Qualmann <metzpinguin at gmail.com> wrote:
> Strange, timestampupdatetest works, digiKam crashes with the test image
> (1.jpg).
>
> Maik
>
> Am Donnerstag, 3. August 2017, 18:46:42 CEST schrieb Maik Qualmann:
>> The timestampupdatet test image can also crash digiKam here.
>> I change the line 840 in metaengine_exif.cpp from:
>>
>> // See BUG #184156 comment #13
>> std::string val  = it->print(&exifData);
>> to
>> std::string val  = it->toString();
>>
>> The bug #184156 I can not reproduce by the change.
>>
>> Maik
>>
>> Am Donnerstag, 3. August 2017, 12:31:58 CEST schrieb Maik Qualmann:
>> > I also use openSUSE Tumbleweed and can confirm the crash in
>> > timestampupdatetest. I look at it tonight. The problem with dimagelisttest
>> > is a timeout because GUI input is necessary.

We need to avoid using add_test(dimagelisttest dimagelisttest) in the
cmake if the test require Gui input, or the test needs to be converted
in a unit test.

I will later work on converting some tests(image quality sorter for
example, to true unit tests)

Gilles, did the GSoC students provide some unit testing for their projects?

>> > Maik
>> >
>> > Am Donnerstag, 3. August 2017, 09:48:57 CEST schrieb Veaceslav Munteanu:
>> > > The jekins is on OpenSuse Tumbleweed, which is a rolling release(like
>> > > Archlinux), which means  it has almost the newest packages.
>> > >
>> > > On Wed, Aug 2, 2017 at 8:11 PM, Simon Frei <freisim93 at gmail.com> wrote:
>> > > > It is 0.26, as build logs show (otherwise cmake would have failed and
>> > > > tests never run).
>> > > >
>> > > > On 02/08/17 19:57, Gilles Caulier wrote:
>> > > >> https://build.kde.org/job/Extragear%20digikam%20kf5-qt5%20SUSEQt5.9/3
>> > > >> 93
>> > > >> /t
>> > > >> estReport/(root)/TestSuite/timestampupdatetest/
>> > > >>
>> > > >> ==> welcome to Exiv2 world. OpenSuse version is ??? If 0.25 => need
>> > > >> 0.26 urgently...
>> > > >>
>> > > >> Gilles
>> > > >>
>> > > >> 2017-08-02 19:47 GMT+02:00 Veaceslav Munteanu
>> >
>> > <veaceslav.munteanu90 at gmail.com>:
>> > > >>> Hello Gilles,
>> > > >>>
>> > > >>> I see it on Jenkins at build.kde.org
>> > > >>>
>> > > >>> On Aug 2, 2017 5:46 PM, "Gilles Caulier" <caulier.gilles at gmail.com>
>> >
>> > wrote:
>> > > >>>> Hi Veaceslav,
>> > > >>>>
>> > > >>>> Where do you see this kind of problem with test units ? On your
>> > > >>>> computer ? On Phabricator ?
>> > > >>>>
>> > > >>>> Gilles
>> > > >>>>
>> > > >>>> 2017-08-02 9:40 GMT+02:00 Veaceslav Munteanu
>> > > >>>>
>> > > >>>> <veaceslav.munteanu90 at gmail.com>:
>> > > >>>>> Hello developers,
>> > > >>>>>
>> > > >>>>> before KDe moved to a new CI, I fixed all the unit tests from
>> > > >>>>> digiKam
>> > > >>>>> to
>> > > >>>>> pass.
>> > > >>>>>
>> > > >>>>> Now it looks like two tests are failing:
>> > > >>>>>
>> > > >>>>> 1. One is a crash in exiv
>> > > >>>>> 2. It seems that an UI tool was added as test, since it times
>> > > >>>>> out...
>> > > >>>>>
>> > > >>>>>
>> > > >>>>> Can somebody take a look? (I do not have internet connectivity at
>> > > >>>>> home... )
>> > > >>>>>
>> > > >>>>> Veaceslav