Review Request 128927: Add namespace to desktop and appdata files

Luigi Toscano luigi.toscano at tiscali.it
Fri Sep 16 23:15:09 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128927/
-----------------------------------------------------------

Review request for Digikam.


Repository: digikam


Description
-------

- add the organization namespace to the desktop (and then appdata) files of digikam and showfoto.
- use the specific variable to find the directory of metadata (appstream) files.


Diffs
-----

  app/CMakeLists.txt 2159d51 
  app/main/digikam.appdata.xml 0a239f9 
  app/main/digikam.desktop  
  showfoto/CMakeLists.txt 6bd490d 
  showfoto/main/showfoto.appdata.xml f04eae1 
  showfoto/main/showfoto.desktop  

Diff: https://git.reviewboard.kde.org/r/128927/diff/


Testing
-------

The code compiles  and the files are installed in the appropriate location.

The use of namespace is moving from "strongly suggested" to "mandatory"...


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20160916/8e77220d/attachment.html>


More information about the Digikam-devel mailing list