New Defects reported by Coverity Scan for digiKam

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.

1 new defect(s) introduced to digiKam found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1372463:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/setup/moc_setupeditor.cpp: 85 in Digikam::SetupEditor::qt_metacall(QMetaObject::Call, int, void **)()


________________________________________________________________________________________________________
*** CID 1372463:  Incorrect expression  (IDENTICAL_BRANCHES)
/core/utilities/setup/moc_setupeditor.cpp: 85 in Digikam::SetupEditor::qt_metacall(QMetaObject::Call, int, void **)()
79         return QScrollArea::qt_metacast(_clname);
80     }
81     
82     int Digikam::SetupEditor::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83     {
84         _id = QScrollArea::qt_metacall(_c, _id, _a);
>>>     CID 1372463:  Incorrect expression  (IDENTICAL_BRANCHES)
>>>     The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85         if (_id < 0)
86             return _id;
87         return _id;
88     }


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZIlZa20oQ0xtvekoaSXYBwgZYh7yqZ4T857KvBwnvzEg-3D-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTAb-2B5mGPmsQ6meEgYXZymYADew3eYnTkBWRkMpxpWBhBXeuuA2l740uyMmGtZDWID-2FRqz6CWSHXxxpWdHaiVopQyPbNBR9xZL5DH6NYfIDWRDTvwvpK-2BtWQe7U60sWAcKkwcpDM5pNiG3JUpejqS1GjP0LPnHxCY3rjf8SNxopAWDUkJ5HTVvK81JqZ4ZZ6iiU-3D

To manage Coverity Scan email notifications for "digikam-devel at kde.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4g-2BkTwi3e7HlDkvMAkUMj2-2FFhZ2O-2BELTTy-2Fl1ea1gxKqmntchu8-2BeAOkExRtki0102MqL9th0o1rOws5-2F-2FQDFdjkpeJaB-2FdUMxPk-2B7ZQUGV0-3D_Vulo-2FzB1zz6bqp-2F-2Bl-2FpBD-2BzKk1Nu56XtBupWJitvnTAb-2B5mGPmsQ6meEgYXZymYAHeINTac9G5DnONCkPnW7L3ccJ2-2FbG2WV7MKHIG2x5BCwaK5GfXEO9yooQv58LcZIpY5n78UIy7ZhW24BXOBbX90CtdWhoPuGwlILvSZ4egDdpoIt9dOIba8dL2bREcvvEfQlAl35JTL3RMrlRZ61yFg8xb-2Bg-2BuAjihPXeOGyMHI-3D