Patch: adjust grouping behaviour

[Gilles Caulier]

Hi Simon,

Thanks for your patches. It's very appreciate.

Please, in the future, do not send patches and bugfixes directly in mailing
list. Use bugzilla instead. Attachments size in ML is limited.

I created one with all patches :

https://bugs.kde.org/show_bug.cgi?id=372027

Best

Gilles Caulier

2016-11-03 13:00 GMT+01:00 Simon Frei <freisim93 at gmail.com>:

> Currently when a grouped image is selected all operations (tagging,
> renaming, ...) are only applied to the head of the group. This is not
> consistent with the options to display items: In iconview, there is
> grouped and ungrouped, in tableview ungrouped, grouped and tree. So I
> have control over whether I want to display images individually or as
> groups. However this control does not extend to actions.
>
> The attached patches change the behaviour:
> When images are grouped or not expanded in treeview, actions apply to
> the selected images and the grouped images. In Ungrouped view or when
> images are expanded in treeview, actions apply only to the selected images.
>
> In the process I uncovered some more or less related issues, that is why
> I have split the patch up. Every single one is functional.
> "allchanges.diff" is, as it name suggests, the combination of all the
> other patches.
>
> grouping.diff
> This is the main change that alters the behaviour as described above.
>
> connect.diff
> Currently there is no tracking of whether items are expanded or not in
> treeview. This results in erratic behaviour, e.g. tagging applies to
> different images depending on cursor moves before. This connects the
> treeview expanded and collapsed signals to the signal, that signifies
> that anything has changed.
>
> rename.diff
> Currently the interactive rename function is executed in the iconview
> context in any case. Now it is executed in the currently active view for
> correct selection.
>
> next.diff
> Little correction where a change was always applied to iconview, now it
> is correctly applied to whichever view is currently active.
>
> All the changes are also available on https://github.com/imsodin/digiKam
> if that is more convenient. This is related to bug 294578.
>
> Cheers,
> Simon
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20161103/2814e8cb/attachment.html>