[Digikam-devel] [digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [patch]

via KDE Bugzilla bugzilla_noreply at kde.org
Mon May 2 14:48:25 BST 2016


--- Comment #33 from caulier.gilles at gmail.com ---
In your stack proposal has the stack icon over the thumb. This one is already
outside the thumb because it's clickable to open/close the stack. If you move
it over the thumb, as the thumb is also clickable, this will not work. So the
icon must still outside the thumb.

The large border in gray delimit a the stack in a more visible way, and it's
more suitable. But a simple large gray border is not enough. We need rotated
border pixmap inside this gray area.

Note about your last patch V2 : 

static const int IMAGE_BORDER_RADIUS = 3; 
const int radius = IMAGE_BORDER_RADIUS;

...is not necessary.

2/ use more CR in you cod. no need to attach all lines together.

3/ No need a cast here : 

const_cast<DItemDelegate*>(this)->d->thumbnailBorderCache.insert(cacheKey, new

d->thumbnailBorderCache.insert(cacheKey, new QPixmap(pix)); must be enough. Do
not try to make JAVA coding style please.

Gilles Caulier

You are receiving this mail because:
You are the assignee for the bug.

More information about the Digikam-devel mailing list