[Digikam-devel] [digikam] [Bug 363697] Album visible even after deletion [patch]

[Richard Mortimer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363697

--- Comment #20 from Richard Mortimer <richm+kde at oldelvet.org.uk> ---
I like the look of Maik's patch. It does seem to be working in a portable way
that does not rely on any magic database primary key values. A deleted
AlbumRoot is easy to identify too.

A few comments on the patch:

the magic relativePath value "*deleted*" should really be a constant that is
used throughout the application. That way it is easier to ensure consistency
and find places where the value is used.

I haven't looked but does addAlbumRoot cope gracefully with situations where
there is already an existing albumRoot for deleted? If not then the code needs
to check for presence of a deleted album root before trying to add one.

-- 
You are receiving this mail because:
You are the assignee for the bug.