[Digikam-devel] [digikam] [Bug 366219] Setting up internal mysql database fails [patch]

Simon via KDE Bugzilla bugzilla_noreply at kde.org
Sat Jul 30 00:22:37 BST 2016


https://bugs.kde.org/show_bug.cgi?id=366219

--- Comment #9 from Simon <freisim93 at gmail.com> ---
Created attachment 100382
  --> https://bugs.kde.org/attachment.cgi?id=100382&action=edit
minor patch on top of maiks commits

Thanks Maik for going over it and improve it. I have some minor points to add
(additional.patch):
 - Aren't the i18n calls in the arguments to processErrorLog redundant as this
argument is later on passed to i18n again?
- One minor improvement over my own patch: In createMysqlFiles only create
initCmdArgs if really necessary.

The following questions are purely out of curiosity/my education, so feel free
to ignore it, but I would appreciate a short answer:
- You removed my struct workaround to make the private variables const.
Obviously this is because my workaround was ugly and cumbersome. Is there a
better way to make them const or is this in any case a useless thing to do?
- Why is the msg argument to processErrorLog declared as a reference?

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Digikam-devel mailing list