[Digikam-devel] Review Request 126872: Fix database setting widget when mysql=on but internalmysql=off

Xuetian Weng wengxt at gmail.com
Sun Jan 24 21:26:55 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126872/
-----------------------------------------------------------

(Updated Jan. 24, 2016, 9:26 p.m.)


Review request for Digikam and Gilles Caulier.


Changes
-------

some places miss dbTypeMap usage


Repository: digikam


Description
-------

Basically the issue is DatabaseType enum value mismatch with dbType QComboBox index.

Add a new member dbTypeMap to help map enum value to index, and uses currentData() and itemData(index) when needed to get the actual enum value.


Diffs (updated)
-----

  libs/database/utils/dbsettingswidget.cpp 668c36c 

Diff: https://git.reviewboard.kde.org/r/126872/diff/


Testing
-------

mysql enabled and internal mysql disabled, select database type mysql (experimental) from settings, UI updates correctly.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20160124/2284491e/attachment.html>


More information about the Digikam-devel mailing list