[digikam] [Bug 366630] digiKam Not Responding if 'Right Click' on a empty area below the album lists

via KDE Bugzilla bugzilla_noreply at kde.org
Thu Aug 11 12:35:43 BST 2016


https://bugs.kde.org/show_bug.cgi?id=366630

--- Comment #2 from caulier.gilles at gmail.com ---
Can be relevant of Coverity Scan report #1368976 :

1083void AbstractAlbumTreeView::contextMenuEvent(QContextMenuEvent* event)
1084{
1085    if (!d->enableContextMenu)
1086    {
1087        return;
1088    }
1089
1090    Album* const album =
albumFilterModel()->albumForIndex(indexAt(event->pos()));
1091
        deref_ptr_in_call: Dereferencing pointer album. [show details]
1092    if (album->isTrashAlbum())
1093    {
1094        // For the moment, disabling context menu for trash.
1095        // TODO : customize it.
1096        return;
1097    }
1098
1099    if (!showContextMenuAt(event, album))
1100    {
1101        return;
1102    }
1103
1104    // switch to the selected album if need

CID 1368976 (#1 of 1): Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking album suggests that it may be null, but it has
already been dereferenced on all paths leading to the check.
1105    if (d->selectOnContextMenu && album)
1106    {
1107        setCurrentAlbums(QList<Album*>() << album);
1108    }

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Digikam-devel mailing list