[Digikam-devel] New Defects reported by Coverity Scan for digiKam
scan-admin at coverity.com
scan-admin at coverity.com
Fri Apr 15 19:45:46 BST 2016
Hi,
Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.
6 new defect(s) introduced to digiKam found with Coverity Scan.
4 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)
** CID 1358543: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/extra/kipi-plugins/googleservices/gswidget.cpp: 94 in KIPIGoogleServicesPlugin::GoogleServicesWidget::GoogleServicesWidget(QWidget *, KIPI::Interface *, const KIPIGoogleServicesPlugin::PluginName &, const QString &)()
________________________________________________________________________________________________________
*** CID 1358543: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/extra/kipi-plugins/googleservices/gswidget.cpp: 94 in KIPIGoogleServicesPlugin::GoogleServicesWidget::GoogleServicesWidget(QWidget *, KIPI::Interface *, const KIPIGoogleServicesPlugin::PluginName &, const QString &)()
88 break;
89 default:
90 getUploadBox()->hide();
91 getSizeBox()->hide();
92 break;
93 }
>>> CID 1358543: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_tagsBGrp" is not initialized in this constructor nor in any functions that it calls.
94 }
95
96 GoogleServicesWidget::~GoogleServicesWidget()
97 {
98 }
99
** CID 1358542: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/widgets/common/dfontproperties.cpp: 121 in DFontProperties::Private::Private(DFontProperties*)()
________________________________________________________________________________________________________
*** CID 1358542: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/widgets/common/dfontproperties.cpp: 121 in DFontProperties::Private::Private(DFontProperties*)()
115 palette.setColor(QPalette::Active, QPalette::Text, Qt::black);
116 palette.setColor(QPalette::Active, QPalette::Base, Qt::white);
117 signalsAllowed = true;
118 selectedSize = -1;
119 customSizeRow = -1;
120 usingFixed = true;
>>> CID 1358542: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "sizeIsRelativeCheckBox" is not initialized in this constructor nor in any functions that it calls.
121 }
122
123 void setFamilyBoxItems(const QStringList& fonts);
124 void fillFamilyListBox(bool onlyFixedFonts = false);
125 int nearestSizeRow(qreal val, bool customize);
126 qreal fillSizeList(const QList<qreal>& sizes = QList<qreal>());
** CID 1358541: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/dialogs/dconfigdlgview.cpp: 368 in Digikam::DConfigDlgViewPrivate::DConfigDlgViewPrivate(Digikam::DConfigDlgView *)()
________________________________________________________________________________________________________
*** CID 1358541: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/dialogs/dconfigdlgview.cpp: 368 in Digikam::DConfigDlgViewPrivate::DConfigDlgViewPrivate(Digikam::DConfigDlgView *)()
362 faceType(DConfigDlgView::Auto),
363 layout(0),
364 stack(0),
365 titleWidget(0),
366 view(0)
367 {
>>> CID 1358541: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "defaultWidget" is not initialized in this constructor nor in any functions that it calls.
368 }
369
370 void DConfigDlgViewPrivate::init()
371 {
372 Q_Q(DConfigDlgView);
373 layout = new QGridLayout(q);
** CID 1358540: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/dialogs/dconfigdlgwidgets_p.h: 68 in Digikam::DConfigDlgTitle::Private::Private(Digikam::DConfigDlgTitle*)()
________________________________________________________________________________________________________
*** CID 1358540: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/dialogs/dconfigdlgwidgets_p.h: 68 in Digikam::DConfigDlgTitle::Private::Private(Digikam::DConfigDlgTitle*)()
62
63 Private(DConfigDlgTitle* parent)
64 : q(parent),
65 autoHideTimeout(0),
66 messageType(InfoMessage)
67 {
>>> CID 1358540: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "commentLabel" is not initialized in this constructor nor in any functions that it calls.
68 }
69
70 QString textStyleSheet() const
71 {
72 const int fontSize = qRound(QApplication::font().pointSize() * 1.4);
73 return QString::fromLatin1("QLabel { font-size: %1pt; color: %2 }")
** CID 1358539: Incorrect expression (IDENTICAL_BRANCHES)
/core/libs/dialogs/moc_dconfigdlgview_p.cpp: 380 in Digikam::DConfigDlgInternal::DConfigDlgListViewDelegate::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1358539: Incorrect expression (IDENTICAL_BRANCHES)
/core/libs/dialogs/moc_dconfigdlgview_p.cpp: 380 in Digikam::DConfigDlgInternal::DConfigDlgListViewDelegate::qt_metacall(QMetaObject::Call, int, void **)()
374 return QAbstractItemDelegate::qt_metacast(_clname);
375 }
376
377 int Digikam::DConfigDlgInternal::DConfigDlgListViewDelegate::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
378 {
379 _id = QAbstractItemDelegate::qt_metacall(_c, _id, _a);
>>> CID 1358539: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
380 if (_id < 0)
381 return _id;
382 return _id;
383 }
384 struct qt_meta_stringdata_Digikam__DConfigDlgInternal__DConfigDlgListViewProxy_t {
385 QByteArrayData data[3];
** CID 1358538: Incorrect expression (IDENTICAL_BRANCHES)
/core/libs/dialogs/moc_dconfigdlgmodels.cpp: 85 in Digikam::DConfigDlgModel::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1358538: Incorrect expression (IDENTICAL_BRANCHES)
/core/libs/dialogs/moc_dconfigdlgmodels.cpp: 85 in Digikam::DConfigDlgModel::qt_metacall(QMetaObject::Call, int, void **)()
79 return QAbstractItemModel::qt_metacast(_clname);
80 }
81
82 int Digikam::DConfigDlgModel::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = QAbstractItemModel::qt_metacall(_c, _id, _a);
>>> CID 1358538: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }
89 struct qt_meta_stringdata_Digikam__DConfigDlgWdgItem_t {
90 QByteArrayData data[12];
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/digikam?tab=overview
To manage Coverity Scan email notifications for "digikam-devel at kde.org", click https://scan.coverity.com/subscriptions/edit?email=digikam-devel%40kde.org&token=621bfe7450f4a870432a2a9c106aa3a8
More information about the Digikam-devel
mailing list