[Digikam-devel] [digikam] [Bug 361047] Wishlist: make grouped images more prominently visible [MOCKUP]

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=361047

caulier.gilles at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mohammed.ahmed.anwer at gmail.
                   |                            |com

--- Comment #6 from caulier.gilles at gmail.com ---
Hi Mohamed and Omar,

I identify better where the code must be patched exactly :

https://quickgit.kde.org/?p=digikam.git&a=blob&h=35b917742c0a0eee08c453f0235190c87404b403&hb=f6e0fba7025fbbe5f9cd1d4fc8b16f88a5d0928e&f=libs%2Fwidgets%2Fitemview%2Fitemviewimagedelegate.cpp

In this implementation, the method ItemViewImageDelegate::drawThumbnail() from
the icon-view model is used by view class to draw the border over the
thumbnail.

The border pixmap is get through the call.

QPixmap borderPix = thumbnailBorderPixmap(actualPixmapRect.size());

This model class don't know if it's a grouped item or not. The view class know
this property. For ex, to draw the grouped icon, we call from view class the
method in the model  : ItemViewImageDelegate::drawGroupIndicator().

So i propose:

1/ to pass as argument a new bool value to
ItemViewImageDelegate::drawThumbnail() to indicate the grouped properties. This
properties will be get in view class (see how
ItemViewImageDelegate::drawGroupIndicator() is called).

2/ To implement relevant code in ItemViewImageDelegate::drawThumbnail() to draw
grouped frame over the current border pixmap. I'm not sure if additional
rotated border as proposed in this entry will be the best visual solution.
Experimentation is welcome.

Gilles Caulier

-

-- 
You are receiving this mail because:
You are the assignee for the bug.