[Digikam-devel] Review Request 125381: Fix OpenCV finding for v3 with disabled ENABLE_OPENCV3

[Gilles Caulier]

> On Sept. 24, 2015, 8:32 p.m., Gilles Caulier wrote:
> > Ship It!
> 
> Gilles Caulier wrote:
>     Your patch is not fine. OpenCV2 and OpenCV3 required components are not the same  (renamed and moved between packages).
>     
>     Enabling OpenCV3 support if OpenCV 2 is expected cannot be done as well. This is why these 2 rules exist and are different in cmake code.

Note : libkface has also the same rules (frameworks and master)


- Gilles


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125381/#review85884
-----------------------------------------------------------


On Sept. 24, 2015, 5:37 p.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125381/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 5:37 p.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Repository: digikam
> 
> 
> Description
> -------
> 
> When have OpenCV v3 but ENABLE_OPENCV3 isn't enabled then CMake will fail to find OpenCV with message
> 
> -- Great, found OpenCV on the first try.
> -- OpenCV Root directory is: /usr/share/opencv
> -- OpenCV: Found version 3.0.0 (required: 2.4.9)
> -- OpenCV headers: /usr/include/opencv;/usr/include
> -- OpenCV libs   : opencv_core;opencv_highgui;opencv_objdetect;opencv_imgproc
> -- ENABLE_OPENCV3 option is disabled and OpenCV >= 3.0.0 have been found. **Enabled ENABLE_OPENCV3**
> CMake Error at cmake/modules/MacroUtils.cmake:44 (message):
>    libopencv is needs. You need to install the libopencv (version >= 2.4.9) development package.
> Call Stack (most recent call first):
>    CMakeLists.txt:425 (PRINT_LIBRARY_STATUS)
> 
> 
> For this case just enable ENABLE_OPENCV3
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 94d5855332f1a4ecf3f7bd5117dff7d56810ff31 
> 
> Diff: https://git.reviewboard.kde.org/r/125381/diff/
> 
> 
> Testing
> -------
> 
> It finds OpenCV
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20150924/b9e608f9/attachment.html>