[Digikam-devel] New Defects reported by Coverity Scan for digiKam
scan-admin at coverity.com
scan-admin at coverity.com
Wed Sep 23 20:13:23 BST 2015
Hi,
Please find the latest report on new defect(s) introduced to digiKam found with Coverity Scan.
17 new defect(s) introduced to digiKam found with Coverity Scan.
32 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 17 of 17 defect(s)
** CID 1324846: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/setup/setupmisc.cpp: 71 in Digikam::SetupMisc::Private::Private()()
________________________________________________________________________________________________________
*** CID 1324846: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/setup/setupmisc.cpp: 71 in Digikam::SetupMisc::Private::Private()()
65 showPermanentDeleteDialogCheck(0),
66 sidebarApplyDirectlyCheck(0),
67 sidebarType(0),
68 stringComparisonType(0),
69 applicationStyle(0)
70 {
>>> CID 1324846: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "scrollItemToCenterCheck" is not initialized in this constructor nor in any functions that it calls.
71 }
72
73 QLabel* sidebarTypeLabel;
74 QLabel* stringComparisonTypeLabel;
75 QLabel* applicationStyleLabel;
76
** CID 1324845: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/geolocation/editor/items/gpsimagemodel.cpp: 42 in Digikam::GPSImageModel::Private::Private()()
________________________________________________________________________________________________________
*** CID 1324845: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/utilities/geolocation/editor/items/gpsimagemodel.cpp: 42 in Digikam::GPSImageModel::Private::Private()()
36 public:
37
38 Private()
39 : items(),
40 columnCount(0)
41 {
>>> CID 1324845: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "thumbnailLoadThread" is not initialized in this constructor nor in any functions that it calls.
42 }
43
44 QList<GPSImageItem*> items;
45 int columnCount;
46 QMap<QPair<int, int>, QVariant> headerData;
47 ThumbnailLoadThread* thumbnailLoadThread;
** CID 1324844: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/dmetadata/dmetadatasettingscontainer.cpp: 74 in Digikam::DMetadataSettingsContainer::DMetadataSettingsContainer(const Digikam::DMetadataSettingsContainer&)()
________________________________________________________________________________________________________
*** CID 1324844: Uninitialized members (UNINIT_CTOR)
/home/gilles/Devel/5.x/core/libs/dmetadata/dmetadatasettingscontainer.cpp: 74 in Digikam::DMetadataSettingsContainer::DMetadataSettingsContainer(const Digikam::DMetadataSettingsContainer&)()
68 }
69
70 DMetadataSettingsContainer::DMetadataSettingsContainer(const DMetadataSettingsContainer& other)
71 : d(new Private)
72 {
73 *d = *other.d;
>>> CID 1324844: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "unifyReadWrite" is not initialized in this constructor nor in any functions that it calls.
74 }
75
76 DMetadataSettingsContainer& DMetadataSettingsContainer::operator=(const DMetadataSettingsContainer& other)
77 {
78 *d = *other.d;
79 return *this;
** CID 1324843: Incorrect expression (IDENTICAL_BRANCHES)
/core/tests/geolocation/geoiface/demo/moc_mydragdrophandler.cpp: 153 in MyDragDropHandler::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324843: Incorrect expression (IDENTICAL_BRANCHES)
/core/tests/geolocation/geoiface/demo/moc_mydragdrophandler.cpp: 153 in MyDragDropHandler::qt_metacall(QMetaObject::Call, int, void **)()
147 return GeoIface::DragDropHandler::qt_metacast(_clname);
148 }
149
150 int MyDragDropHandler::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
151 {
152 _id = GeoIface::DragDropHandler::qt_metacall(_c, _id, _a);
>>> CID 1324843: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
153 if (_id < 0)
154 return _id;
155 return _id;
156 }
** CID 1324842: Incorrect expression (IDENTICAL_BRANCHES)
/core/libs/widgets/moc_msgtextedit.cpp: 85 in Digikam::MsgTextEdit::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324842: Incorrect expression (IDENTICAL_BRANCHES)
/core/libs/widgets/moc_msgtextedit.cpp: 85 in Digikam::MsgTextEdit::qt_metacall(QMetaObject::Call, int, void **)()
79 return KTextEdit::qt_metacast(_clname);
80 }
81
82 int Digikam::MsgTextEdit::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = KTextEdit::qt_metacall(_c, _id, _a);
>>> CID 1324842: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }
** CID 1324841: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_mapdragdrophandler.cpp: 85 in Digikam::MapDragData::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324841: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_mapdragdrophandler.cpp: 85 in Digikam::MapDragData::qt_metacall(QMetaObject::Call, int, void **)()
79 return QMimeData::qt_metacast(_clname);
80 }
81
82 int Digikam::MapDragData::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = QMimeData::qt_metacall(_c, _id, _a);
>>> CID 1324841: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }
89 struct qt_meta_stringdata_Digikam__MapDragDropHandler_t {
90 QByteArrayData data[1];
** CID 1324840: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_mapdragdrophandler.cpp: 153 in Digikam::MapDragDropHandler::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324840: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_mapdragdrophandler.cpp: 153 in Digikam::MapDragDropHandler::qt_metacall(QMetaObject::Call, int, void **)()
147 return GeoIface::DragDropHandler::qt_metacast(_clname);
148 }
149
150 int Digikam::MapDragDropHandler::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
151 {
152 _id = GeoIface::DragDropHandler::qt_metacall(_c, _id, _a);
>>> CID 1324840: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
153 if (_id < 0)
154 return _id;
155 return _id;
156 }
** CID 1324839: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_searchresultmodel.cpp: 85 in Digikam::SearchResultModel::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324839: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_searchresultmodel.cpp: 85 in Digikam::SearchResultModel::qt_metacall(QMetaObject::Call, int, void **)()
79 return QAbstractItemModel::qt_metacast(_clname);
80 }
81
82 int Digikam::SearchResultModel::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = QAbstractItemModel::qt_metacall(_c, _id, _a);
>>> CID 1324839: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }
** CID 1324838: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_gpsimagesortproxymodel.cpp: 85 in Digikam::GPSImageSortProxyModel::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324838: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_gpsimagesortproxymodel.cpp: 85 in Digikam::GPSImageSortProxyModel::qt_metacall(QMetaObject::Call, int, void **)()
79 return QSortFilterProxyModel::qt_metacast(_clname);
80 }
81
82 int Digikam::GPSImageSortProxyModel::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = QSortFilterProxyModel::qt_metacall(_c, _id, _a);
>>> CID 1324838: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }
** CID 1324837: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_gpsimageitemdelegate.cpp: 85 in Digikam::GPSImageItemDelegate::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324837: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_gpsimageitemdelegate.cpp: 85 in Digikam::GPSImageItemDelegate::qt_metacall(QMetaObject::Call, int, void **)()
79 return QItemDelegate::qt_metacast(_clname);
80 }
81
82 int Digikam::GPSImageItemDelegate::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = QItemDelegate::qt_metacall(_c, _id, _a);
>>> CID 1324837: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }
** CID 1324836: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_gpsimagelistdragdrophandler.cpp: 153 in Digikam::GPSImageListDragDropHandler::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324836: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_gpsimagelistdragdrophandler.cpp: 153 in Digikam::GPSImageListDragDropHandler::qt_metacall(QMetaObject::Call, int, void **)()
147 return ImageListDragDropHandler::qt_metacast(_clname);
148 }
149
150 int Digikam::GPSImageListDragDropHandler::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
151 {
152 _id = ImageListDragDropHandler::qt_metacall(_c, _id, _a);
>>> CID 1324836: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
153 if (_id < 0)
154 return _id;
155 return _id;
156 }
** CID 1324835: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_gpsimagelistdragdrophandler.cpp: 85 in Digikam::ImageListDragDropHandler::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324835: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/editor/moc_gpsimagelistdragdrophandler.cpp: 85 in Digikam::ImageListDragDropHandler::qt_metacall(QMetaObject::Call, int, void **)()
79 return QObject::qt_metacast(_clname);
80 }
81
82 int Digikam::ImageListDragDropHandler::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = QObject::qt_metacall(_c, _id, _a);
>>> CID 1324835: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }
89 struct qt_meta_stringdata_Digikam__GPSImageListDragDropHandler_t {
90 QByteArrayData data[1];
** CID 1324834: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/moc_dragdrophandler.cpp: 85 in GeoIface::DragDropHandler::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324834: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/moc_dragdrophandler.cpp: 85 in GeoIface::DragDropHandler::qt_metacall(QMetaObject::Call, int, void **)()
79 return QObject::qt_metacast(_clname);
80 }
81
82 int GeoIface::DragDropHandler::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = QObject::qt_metacall(_c, _id, _a);
>>> CID 1324834: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }
** CID 1324833: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/moc_tilegrouper.cpp: 85 in GeoIface::TileGrouper::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324833: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/moc_tilegrouper.cpp: 85 in GeoIface::TileGrouper::qt_metacall(QMetaObject::Call, int, void **)()
79 return QObject::qt_metacast(_clname);
80 }
81
82 int GeoIface::TileGrouper::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = QObject::qt_metacall(_c, _id, _a);
>>> CID 1324833: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }
** CID 1324832: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/moc_geoiface_common.cpp: 85 in GeoIface::GeoIfaceGlobalObject::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324832: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/moc_geoiface_common.cpp: 85 in GeoIface::GeoIfaceGlobalObject::qt_metacall(QMetaObject::Call, int, void **)()
79 return QObject::qt_metacast(_clname);
80 }
81
82 int GeoIface::GeoIfaceGlobalObject::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = QObject::qt_metacall(_c, _id, _a);
>>> CID 1324832: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }
** CID 1324831: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/moc_placeholderwidget.cpp: 85 in GeoIface::PlaceholderWidget::qt_metacall(QMetaObject::Call, int, void **)()
________________________________________________________________________________________________________
*** CID 1324831: Incorrect expression (IDENTICAL_BRANCHES)
/core/utilities/geolocation/geoiface/moc_placeholderwidget.cpp: 85 in GeoIface::PlaceholderWidget::qt_metacall(QMetaObject::Call, int, void **)()
79 return QFrame::qt_metacast(_clname);
80 }
81
82 int GeoIface::PlaceholderWidget::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
83 {
84 _id = QFrame::qt_metacall(_c, _id, _a);
>>> CID 1324831: Incorrect expression (IDENTICAL_BRANCHES)
>>> The same code is executed when the condition "_id < 0" is true or false, because the code in the if-then branch and after the if statement is identical. Should the if statement be removed?
85 if (_id < 0)
86 return _id;
87 return _id;
88 }
** CID 1324830: (CHECKED_RETURN)
/home/gilles/Devel/5.x/core/utilities/geolocation/editor/correlator/gpscorrelatorwidget.cpp: 590 in Digikam::GPSCorrelatorWidget::slotAllItemsCorrelated()()
/home/gilles/Devel/5.x/core/utilities/geolocation/editor/correlator/gpscorrelatorwidget.cpp: 601 in Digikam::GPSCorrelatorWidget::slotAllItemsCorrelated()()
________________________________________________________________________________________________________
*** CID 1324830: (CHECKED_RETURN)
/home/gilles/Devel/5.x/core/utilities/geolocation/editor/correlator/gpscorrelatorwidget.cpp: 590 in Digikam::GPSCorrelatorWidget::slotAllItemsCorrelated()()
584 }
585
586 void GPSCorrelatorWidget::slotAllItemsCorrelated()
587 {
588 if (d->correlationCorrelatedCount==0)
589 {
>>> CID 1324830: (CHECKED_RETURN)
>>> Calling "warning" without checking return value (as is done elsewhere 36 out of 42 times).
590 QMessageBox::warning(this, i18n("Correlation failed"),
591 i18n("Could not correlate any image - please make sure the timezone and gap settings are correct."));
592 }
593 else if (d->correlationCorrelatedCount==d->correlationTotalCount)
594 {
595 QMessageBox::information(this, i18n("Correlation succeeded"),
/home/gilles/Devel/5.x/core/utilities/geolocation/editor/correlator/gpscorrelatorwidget.cpp: 601 in Digikam::GPSCorrelatorWidget::slotAllItemsCorrelated()()
595 QMessageBox::information(this, i18n("Correlation succeeded"),
596 i18n("All images have been correlated. You can now check their position on the map."));
597 }
598 else
599 {
600 // note: no need for i18np here, because the case of correlationTotalCount==1 is covered in the other two cases.
>>> CID 1324830: (CHECKED_RETURN)
>>> Calling "warning" without checking return value (as is done elsewhere 36 out of 42 times).
601 QMessageBox::warning(this, i18n("Correlation finished"),
602 i18n("%1 out of %2 images have been correlated. Please check the timezone and gap settings if you think that more images should have been correlated.",
603 d->correlationCorrelatedCount, d->correlationTotalCount));
604 }
605
606 if (d->correlationCorrelatedCount==0)
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/digikam?tab=overview
To manage Coverity Scan email notifications for "digikam-devel at kde.org", click https://scan.coverity.com/subscriptions/edit?email=digikam-devel%40kde.org&token=621bfe7450f4a870432a2a9c106aa3a8
More information about the Digikam-devel
mailing list