[Digikam-devel] Review Request 125551: Link to more libraries for dngwriter

Dāvis Mosāns davispuh at gmail.com
Wed Oct 14 19:52:13 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125551/
-----------------------------------------------------------

(Updated Oct. 14, 2015, 9:52 p.m.)


Status
------

This change has been discarded.


Review request for Digikam.


Repository: digikam


Description
-------

Currently when compiliing with ENABLE_AKONADICONTACTSUPPORT=ON raw2dng linking fails with undefined references such as

```
../libdngwriter.a(dngwriter.cpp.o): In function `Digikam::DNGWriter::convert()':
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:169: undefined reference to `DIGIKAM_GENERAL_LOG()'
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:183: undefined reference to `KDcrawIface::DcrawInfoContainer::DcrawInfoContainer()'
/mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:190: undefined reference to `KDcrawIface::KDcraw::KDcraw()'
```


This RR fixes it by linking to those required libraries.


Diffs
-----

  libs/3rdparty/dngwriter/CMakeLists.txt cc82d0a0c1713d7eab5b53d81c263056d5c88fd7 
  libs/3rdparty/dngwriter/tests/CMakeLists.txt 7fd6136ee652bc3822fc0228059bc84d5302af19 

Diff: https://git.reviewboard.kde.org/r/125551/diff/


Testing
-------

Compiles


Thanks,

Dāvis Mosāns

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20151014/cc9a4ba6/attachment.html>


More information about the Digikam-devel mailing list