[Digikam-devel] Review Request 125551: Link to more libraries for dngwriter

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125551/#review86841
-----------------------------------------------------------


the current implementation fix the problem. please try again

- Gilles Caulier


On Oct. 8, 2015, 12:32 a.m., Dāvis Mosāns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125551/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 12:32 a.m.)
> 
> 
> Review request for Digikam.
> 
> 
> Repository: digikam
> 
> 
> Description
> -------
> 
> Currently when compiliing with ENABLE_AKONADICONTACTSUPPORT=ON raw2dng linking fails with undefined references such as
> 
> ```
> ../libdngwriter.a(dngwriter.cpp.o): In function `Digikam::DNGWriter::convert()':
> /mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:169: undefined reference to `DIGIKAM_GENERAL_LOG()'
> /mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:183: undefined reference to `KDcrawIface::DcrawInfoContainer::DcrawInfoContainer()'
> /mnt/KDE/extragear/graphics/digikam/libs/3rdparty/dngwriter/dngwriter.cpp:190: undefined reference to `KDcrawIface::KDcraw::KDcraw()'
> ```
> 
> 
> This RR fixes it by linking to those required libraries.
> 
> 
> Diffs
> -----
> 
>   libs/3rdparty/dngwriter/CMakeLists.txt cc82d0a0c1713d7eab5b53d81c263056d5c88fd7 
>   libs/3rdparty/dngwriter/tests/CMakeLists.txt 7fd6136ee652bc3822fc0228059bc84d5302af19 
> 
> Diff: https://git.reviewboard.kde.org/r/125551/diff/
> 
> 
> Testing
> -------
> 
> Compiles
> 
> 
> Thanks,
> 
> Dāvis Mosāns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20151014/d23edf51/attachment.html>