[Digikam-devel] [digikam] [Bug 355831] MySQL Schema Improvements

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355831

--- Comment #20 from caulier.gilles at gmail.com ---
>1 - Each of the image, thumbnails and face recognition databases all have a table called Settings. >I can see this causing trouble with all three merged into a single database.

Which trouble exactly ? I already noticed some problem and i fixed this with
face recognition DB integration.

>At a very minimum the migration needs to take care to track this and migrating back to separate >databases would be even harder. Is it going to be feasible to rename the thumbnails and face >recognition tables to something like SettingsThumb and SettingsFace or would that cause too >much trouble with SQLite support?

I thinking about to do the same. I think it's safe if Settings table differ
than SQlite for MySql.

2/ => ok.

3/ => the logic is good. turning on the bool value will stop copy processing.
But in fact an new method need to be add in this class to be able to change
this private bool member from outside (as for ex, when Cancel button is
pressed).

Granularity of bool check to cancel copy must be decreased. typically checking
bool outside the loop will prevent to break partial database copy in the middle
section of data.

In all case a garbage collector must be implemented to cleanup previous copy
while migration. Perhaps to cleanup target database can be enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.