[Digikam-devel] [digikam] [Bug 355831] MySQL Schema Improvements

[Richard Mortimer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355831

--- Comment #18 from Richard Mortimer <richm+kde at oldelvet.org.uk> ---
I have not had chance to look at MySQL upgrade procedure yet - although given
the changes made so far it should just be adding foreign keys so assuming that
the data is not broken due to orphaned records then that should be OK.

Similarly I have not had chance to look at the tags issue on MySQL yet.

A couple of other things I have noticed:

1 - Each of the image, thumbnails and face recognition databases all have a
table called Settings. I can see this causing trouble with all three merged
into a single database. At a very minimum the migration needs to take care to
track this and migrating back to separate databases would be even harder. Is it
going to be feasible to rename the thumbnails and face recognition tables to
something like SettingsThumb and SettingsFace or would that cause too much
trouble with SQLite support?

2 - Currently migration does not seem to handle the faces and thumbnails
databases. Presumably this is planned but just not done yet.

3 - the logic surrounding m_isStopProcessing in coredbcopymanager.cpp looks to
be wrong in places. The loops do a OR operation, e.g. "m_isStopProcessing || i
>=0", but not all of them test m_isStopProcessing to terminate the migration if
that flag is set. 

Also using that way to terminate the loop the migration the code must be
careful not to access the loop counter "i" before terminating because it could
cause an overflow of the tables array if the termination is received during the
processing of the last table being iterated.

-- 
You are receiving this mail because:
You are the assignee for the bug.