[Digikam-devel] Questionable commit to digikam's frameworks branch?

[Marko Käning]

Hi digikam devs,

in discussion with Veaceslav it became obvious that I better subscribe to
this list, as I might have committed something which isn’t really correct.

Teemu, could you check whether my below commit to Baloo’s CMakeLists.txt
is okay or not?

Thanks in advance.

Greets,
Marko


P.S.: There are still two posts of mine in the ML’s pipeline which need
      to be let go through, which is why I CC'ed the ML admin as well.




Begin forwarded message:

> From: Veaceslav Munteanu <veaceslav.munteanu90 at gmail.com>
> Subject: Re: digiKam issues
> Date: 15 Mar 2015 18:36:42 GMT+1
> To: Marko Käning <mk-lists at email.de>
> 
> Please post it on digikam-devel,
> 
> Teemu might be able to help you, he is the one who rewrite the CMake tree.
> 
> It is not the best idea because I think there is a include problem
> rather than linking, and what I did right now was to link in other
> place, except digiKam's executable..
> 
> On Sun, Mar 15, 2015 at 6:31 PM, Marko Käning <mk-lists at email.de> wrote:
>> 
>> On 15 Mar 2015, at 18:14 , Veaceslav Munteanu <veaceslav.munteanu90 at gmail.com> wrote:
>> 
>>> Try adding KF5::I18n to target_link_libraries in /core/utilities/baloo
>>> CMakeFile. Even if it works, I'm not sure it is the correct way ...
>> 
>> It did work, which is why I committed right away:
>> 
>>        http://commits.kde.org/digikam/bacb578e1d21cd06d6e72c528673598d4849851d
>> 
>> only to read then, that you were not sure that it is the correct way…
>> 
>> Too late! =(