[Digikam-devel] digikamadaptop.moc in object library error on older cmake versions

[Alexander Potashev]

On Jul 6, 2015 10:29, "Gilles Caulier" <caulier.gilles at gmail.com> wrote:
>
> For me cmake 3.0.1 under Mageia generate only a warning and compile.
>
> So a minimum cmake to 3.0.0 is safe.
>
> Gilles
>
> 2015-07-06 9:01 GMT+02:00 Veaceslav Munteanu <
veaceslav.munteanu90 at gmail.com>:
>>
>> Hello,
>>
>> that commit of mine was broken and didn't fix the problem. I have
>> Cmake 3.2.3 which generates without errors.
>>
>> I'm not sure, but even if old versions throw an error, you can still
>> build it. Have you tried to run make after?
>>
>> I will try now to find a solution to this problem
>>
>> On Mon, Jul 6, 2015 at 12:27 AM, Alexander Potashev
>> <aspotashev at gmail.com> wrote:
>> > Hi,
>> >
>> > digiKam[frameworks] doesn't build here because I have CMake-2.8.12 and
>> > digikamadaptop.moc is built into an object library.
>> >
>> > What can we do:
>> >  1. Bump CMake version requirement (not sure about minimum version we
>> > need to fix this problem), OR
>> >  2. Cherry-pick the commit [1] into branch frameworks.
>> >
>> > I would prefer the 1st solution. Any objections?
>> >
>> > [1]
http://quickgit.kde.org/?p=digikam.git&a=commit&h=d9d715deaacd4fb6d021ccb3c1fa1120ef183201
>> >

Veaceslav,

For me it fixed the build. I needed to resolve conflicts when cherry
picking, and may the patch went a little different ;)

Gilles,
What kind of warning are you getting?

-- 
Alexander Potashev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/digikam-devel/attachments/20150706/20d46ebf/attachment.html>