[Digikam-devel] [digikam] [Bug 349925] New: Fail cmake chek if -DENABLE_KFILEMETADATASUPPORT=ON is not set (frameworks branch)

[Gustavo Alvarez]

https://bugs.kde.org/show_bug.cgi?id=349925

            Bug ID: 349925
           Summary: Fail cmake chek if -DENABLE_KFILEMETADATASUPPORT=ON is
                    not set (frameworks branch)
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: digikam-devel at kde.org
          Reporter: sl1pkn07 at gmail.com

Hi

The build of the latest commit of digikam frameworks branch, fail if
-DENABLE_KFILEMETADATASUPPORT=ON is not set

this is because the path of KF5:FileMetaData target
(http://quickgit.kde.org/?p=digikam.git&a=blob&h=54ea892109720eb259c1f0f6f951b39e4df5ed88&hb=7ba11d3c599b283a81d7c1ca63ff11d26751f12d&f=CMakeLists.txt#l469)
is always set, though the filemetadata support is has enabled or disabled (by
default is disable)

Removing that line and adding it after, with selector like
http://quickgit.kde.org/?p=digikam.git&a=blob&h=54ea892109720eb259c1f0f6f951b39e4df5ed88&hb=7ba11d3c599b283a81d7c1ca63ff11d26751f12d&f=CMakeLists.txt#l484
fixes the problem

then, if set -DENABLE_KFILEMETADATASUPPORT=ON, adds the target path in
KF5_INCLUDES_ALL.  if set to OFF (or not set), then it will not add (by default
not added)

Reproducible: Always

Steps to Reproduce:
1. download the last digikam frameworks branch commit with git
2. try to build without  -DENABLE_KFILEMETADATASUPPORT=ON


Actual Results:  
cmake configure finish with error

Expected Results:  
cmake configure finish ok

the patch:

http://sl1pkn07.wtf/paste/view/raw/2989952a

(the last part if because my kate eats the "useless" spaces)

-- 
You are receiving this mail because:
You are the assignee for the bug.