[Digikam-devel] [digikam] [Bug 342996] Corrections for rename settings in images import [patch]

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=342996

--- Comment #14 from Gilles Caulier <caulier.gilles at gmail.com> ---
Maik,

Just an important notice :

In frameworks branch dedicated to port digiKam to KF5, KUrl have been replaced
by QUrl.

The simple backport as weel of your patch said :

[ 63%] Building CXX object
core/utilities/importui/CMakeFiles/importui.dir/main/importui.cpp.o
/home/gilles/Devel/KF5/dk-sc/core/utilities/importui/main/importui.cpp: In
member function ‘void Digikam::ImportUI::slotNewSelection(bool)’:
/home/gilles/Devel/KF5/dk-sc/core/utilities/importui/main/importui.cpp:2301:36:
error: no match for ‘operator=’ (operand types are ‘QUrl’ and ‘QString’)
         parseSettings.fileUrl      = info.name;
                                    ^
/home/gilles/Devel/KF5/dk-sc/core/utilities/importui/main/importui.cpp:2301:36:
note: candidates are:
In file included from /usr/lib64/qt5/include/QtGui/qevent.h:48:0,
                 from /usr/lib64/qt5/include/QtGui/QKeyEvent:1,
                 from
/home/gilles/Devel/KF5/dk-sc/core/utilities/importui/main/importui.h:35,
                 from
/home/gilles/Devel/KF5/dk-sc/core/utilities/importui/main/importui.cpp:28:
/usr/lib64/qt5/include/QtCore/qurl.h:168:11: note: QUrl& QUrl::operator=(const
QUrl&)
     QUrl &operator =(const QUrl &copy);
           ^
/usr/lib64/qt5/include/QtCore/qurl.h:168:11: note:   no known conversion for
argument 1 from ‘QString’ to ‘const QUrl&’
/usr/lib64/qt5/include/QtCore/qurl.h:178:18: note: QUrl&
QUrl::operator=(QUrl&&)
     inline QUrl &operator=(QUrl &&other)
                  ^
/usr/lib64/qt5/include/QtCore/qurl.h:178:18: note:   no known conversion for
argument 1 from ‘QString’ to ‘QUrl&&’
core/utilities/importui/CMakeFiles/importui.dir/build.make:997: recipe for
target 'core/utilities/importui/CMakeFiles/importui.dir/main/importui.cpp.o'
failed
make[2]: ***
[core/utilities/importui/CMakeFiles/importui.dir/main/importui.cpp.o] Error 1
CMakeFiles/Makefile2:2040: recipe for target
'core/utilities/importui/CMakeFiles/importui.dir/all' failed
make[1]: *** [core/utilities/importui/CMakeFiles/importui.dir/all] Error 2
Makefile:117: recipe for target 'all' failed
make: *** [all] Error 2

... at this line :

    foreach(CamItemInfo info, list)
    {
        ParseSettings parseSettings;

        parseSettings.fileUrl = info.name;   <<<<<<<<<<<<<<<<<< HERE
        parseSettings.creationTime       = info.ctime;
        renameFiles.append(parseSettings);
    }

That i converted like this in commit :

parseSettings.fileUrl.fileName() = info.name;    // TODO : Qt5 port : check if
KUrl() == QString() replacement is valid here. 

I don't check if it work. At least it compile.

Gilles

-- 
You are receiving this mail because:
You are the assignee for the bug.