[Digikam-devel] [digikam] [Bug 342513] Add support for fractional radius in blur and unsharp mask filters [patch]

pochini at shiny.it pochini at shiny.it
Mon Jan 19 21:58:59 GMT 2015


https://bugs.kde.org/show_bug.cgi?id=342513

--- Comment #7 from pochini at shiny.it ---
Yes, it is not ready yet. Attached is a more complete patch (against 4.6.0)
involving four files:

dimg/filters/fx/blurfilter.cpp: About the same of the previous patch, but
without debug stuff. I also moved the check for too-small-radius outside the
loop and reindented.

dimg/filters/fx/blurfilter.h: changed radius type to float.

dimg/filters/fx/charcoalfilter.cpp: Do not cast smooth/10 to integer.

dimg/filters/sharp/unsharpmaskfilter.cpp: Pass m_radius as-is, instead of
(int)r/10.

Concerning the speed, it is about 25% slower. For example on my pc the time to
blur with radius=3 an 8 bits 15MP image was 650ms and now it is 800ms.

TODO:

- Some users have not been checked yes (watermark, redeyetool, blurfxfilter,
filtermanager?, infraredfilter)
- Am I missing something ?

(ok, don't laugh now, but I can't find those filters in the menus... where are
they ??)

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Digikam-devel mailing list