[Digikam-devel] [digikam] [Bug 342931] New: Wrong apect ratio in item properties and in item view

[Stas]

https://bugs.kde.org/show_bug.cgi?id=342931

            Bug ID: 342931
           Summary: Wrong apect ratio in item properties and in item view
           Product: digikam
           Version: 4.6.0
          Platform: Kubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: general
          Assignee: digikam-devel at kde.org
          Reporter: stas.kazmin at googlemail.com

Hello, I have found that in item properties and also when showing the aspect
ratio in the icon view, the aspect ratio is always 3:2. The search option works
however. So it is a error in displaying the ratio.

I have researched a little bit in the code and have found the error:
in: /core/libs/imageproperties/imagepropertiestab.cpp
line: 949
in function: ImagePropertiesTab::aspectRatioToString()
the following can be found: doubleToHumanReadableFraction((double)nw /
(double)nh, &num, &den);
however the function doubleToHumanReadableFraction has 4 parameters.
Changing it to: doubleToHumanReadableFraction((double)nw / (double)nh, &num,
&den, 10);
solves the problem both in item properties and in icon view.

I would wish that you change it in the next version or on git. But I do not
know whether 10 is the best parameter here.

Thanks for great software anyway.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.