[Digikam-devel] [digikam] [Bug 349601] digikam compile fine with OpenCV 2.X but not with 3.x

[Viktor Jancik]

https://bugs.kde.org/show_bug.cgi?id=349601

--- Comment #8 from Viktor Jancik <vjancik at redhat.com> ---
Created attachment 94097
  --> https://bugs.kde.org/attachment.cgi?id=94097&action=edit
digikam-4.12.0-opencv3.patch

This patch doesn't contain fixes for libkface directly, because digikam is
configured to build with the system version of libkface, so instead I created a
separate patch that fixes the system version of libkface.

Despite that fix, digikam still wouldn't build against OpenCV 3 and had
numerous errors.

cvCreateMat returns cvMat but variable d is of type Mat, a 1 to 1 replacement
was possible with the Mat constructor.
In core/libs/database/imgqsort/imgqsort.cpp vector containers were missing the
std:: namespace prefix. How did it build before?
In
extra/kipi-plugins/removeredeyes/detection/locators/haarclassifier/haarclassifierlocator.cpp
I had to add a definition of cvFillImage because it was removed from OpenCV 3.
The definition is exactly the same as it was in OpenCV 2.4.11.
I had to conditionally disable the building of ipptest because it used a
function that no longer exists in OpenCV 3 (cvGetModuleInfo) and I couldn't
find / create a replacement. As a consequence, I am not sure if the tests pass
properly, because I am not sure if this is a good way to disable a test.
And lastly, I had to modify the includes in 2 libopencv.h files and modify the
OPENCV_TEST_VERSION macros as they didn't work as intended for versions 2.3.0
up to 2.4.X Yes, there are two libopencv.h files.

-- 
You are receiving this mail because:
You are the assignee for the bug.