[Digikam-devel] [digikam] [Bug 350915] New: digikam-4.12.0 fails to compile with jpeg-9a

[Timo Gurr]

https://bugs.kde.org/show_bug.cgi?id=350915

            Bug ID: 350915
           Summary: digikam-4.12.0 fails to compile with jpeg-9a
           Product: digikam
           Version: 4.11.0
          Platform: Exherbo Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: digikam-devel at kde.org
          Reporter: timo.gurr at gmail.com

Despite having a codepath for jpeg9 located at core/libs/jpegutils/libjpeg-91
digikam fails with the following error when trying to build with jpeg-9a:

[...]
Found JPEG: /usr/lib/libjpeg.so
[...]

/var/tmp/paludis/build/graphics-digikam-4.11.0/work/digikam-4.11.0/core/libs/dimg/loaders/jpegloader.cpp:
In member function 'virtual bool Digikam::JPEGLoader::load(const QString&,
Digikam::DImgLoaderObserver*)':
/var/tmp/paludis/build/graphics-digikam-4.11.0/work/digikam-4.11.0/core/libs/dimg/loaders/jpegloader.cpp:253:34:
error: cannot convert 'bool' to 'boolean' for argument '2' to 'int
jpeg_read_header(j_decompress_ptr, boolean)'
     jpeg_read_header(&cinfo, true);
                                  ^
/var/tmp/paludis/build/graphics-digikam-4.11.0/work/digikam-4.11.0/core/libs/dimg/loaders/jpegloader.cpp:303:35:
error: cannot convert 'bool' to 'boolean' in assignment
         cinfo.do_fancy_upsampling = false;
                                   ^
/var/tmp/paludis/build/graphics-digikam-4.11.0/work/digikam-4.11.0/core/libs/dimg/loaders/jpegloader.cpp:304:35:
error: cannot convert 'bool' to 'boolean' in assignment
         cinfo.do_block_smoothing  = false;
                                   ^
/var/tmp/paludis/build/graphics-digikam-4.11.0/work/digikam-4.11.0/core/libs/dimg/loaders/jpegloader.cpp:
In member function 'virtual bool Digikam::JPEGLoader::save(const QString&,
Digikam::DImgLoaderObserver*)':
/var/tmp/paludis/build/graphics-digikam-4.11.0/work/digikam-4.11.0/core/libs/dimg/loaders/jpegloader.cpp:787:43:
error: cannot convert 'bool' to 'boolean' for argument '3' to 'void
jpeg_set_quality(j_compress_ptr, int, boolean)'
     jpeg_set_quality(&cinfo, quality, true);
                                           ^
/var/tmp/paludis/build/graphics-digikam-4.11.0/work/digikam-4.11.0/core/libs/dimg/loaders/jpegloader.cpp:788:37:
error: cannot convert 'bool' to 'boolean' for argument '2' to 'void
jpeg_start_compress(j_compress_ptr, boolean)'
     jpeg_start_compress(&cinfo, true);
                                     ^

Attached patch makes digikam-4.11.0 compile fine and a basic test adding jpegs
to a new album and displaying them worked.

Note: For getting kipi-plugins to compile with jpeg-9a I had to apply a second
patch: https://git.reviewboard.kde.org/r/123886/

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.