[Digikam-devel] [digikam] [Bug 339210] digiKam crashes when trying to stop find duplicates

nucleo nucleo at fedoraproject.org
Fri Sep 19 22:22:10 BST 2014


https://bugs.kde.org/show_bug.cgi?id=339210

--- Comment #5 from nucleo <nucleo at fedoraproject.org> ---
Here commit:

--- a/utilities/maintenance/imageinfojob.cpp
+++ b/utilities/maintenance/imageinfojob.cpp
@@ -110,8 +110,6 @@ bool ImageInfoJob::isRunning() const

 void ImageInfoJob::slotResult(KJob* job)
 {
-    d->job = 0;
-
     if (job->error())
     {
         kWarning() << "Failed to list url: " << job->errorString();
@@ -121,6 +119,8 @@ void ImageInfoJob::slotResult(KJob* job)
                              DigikamApp::instance(),
DigikamApp::instance()->windowTitle());
     }

+    d->job = 0;
+
     emit signalCompleted();
 }



And here actual code from 4.3.0 tarball:

void ImageInfoJob::slotResult(KJob* job)
{
    if (job->error())
    {
        kWarning() << "Failed to list url: " << job->errorString();

        // Pop-up a message about the error.
        DNotificationWrapper(QString(), d->job->errorString(),
                             DigikamApp::instance(),
DigikamApp::instance()->windowTitle());
        return;
    }

    d->job = 0;

    emit signalCompleted();
}

So patch already applied in 4.3.0 sources.

-- 
You are receiving this mail because:
You are the assignee for the bug.



More information about the Digikam-devel mailing list