[Digikam-devel] [digikam] [Bug 326718] Clear text button on file rename does nothing

[Koushik S]

https://bugs.kde.org/show_bug.cgi?id=326718

Koushik S <skoushik333 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |skoushik333 at gmail.com

--- Comment #2 from Koushik S <skoushik333 at gmail.com> ---
(In reply to Teemu Rytilahti from comment #1)
> Hello there,
> 
> Just took a quick peek at the code.
> The widget used is ProxyLineEdit defined in
> libs/widgets/common/comboboxutilities.cpp
> This widget overrides the input events of KLineEdit for some reason, found
> just this comment there:
> /**
>  * We just re-implement all relevant QWidget event handlers and call
>  * the QWidget implementation, not the KLineEdit one.
>  */
> 
> As one can see from here, the signal is being emited in KLineEdit
> implementation, and is not therefore ever emited in this case:
> http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/klineedit_8cpp_source.
> html#l01144
> 
> Marcel probably has insight why it was done so, added to CC.

Hi,

I just changed the mousePressEvent and mouseReleaseEvent to KLineEdit's
implementation and it seems to work, although I'm not sure why it was avoided
in the first place. So i'll hold onto making the patch until it's confirmed
that there's no problems involved.

-- 
You are receiving this mail because:
You are the assignee for the bug.