[Digikam-devel] [digikam] [Bug 340944] Build failed against libjpeg-turbo-1.3.90

[Gilles Caulier]

https://bugs.kde.org/show_bug.cgi?id=340944

--- Comment #10 from Gilles Caulier <caulier.gilles at gmail.com> ---
This approach is not the best way.

Typically, i would not to touch transupp.h, iccjpeg.h because these files are
taken as well from 3rd party lib. updating it in the future require to patch
again the files and this is a possible stage to forget to do.

Also, i think your patch forget other part to patch as jpegutils.cpp for ex,
where jpeglib headers are included.

I tried to do another way in a cmake macro to check if jpeglib define exist or
not with a small compilation process, as it done in this cmake script used to
detect jpeglib version :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/cmake/modules/MacroJPEG.cmake

Accordingly with define detection, the idea is to use add_definitions() like
this for whole compilation :

add_definitions("-DJPP(x) x")

... but of course this doesn't work...

Gilles

PS : no need to use reviewboard, this will duplicates bugzilla workflow (:=)))

-- 
You are receiving this mail because:
You are the assignee for the bug.