[Digikam-devel] [digikam] [Bug 331597] Tags are not sorted in UI [patch]

[Michal Sylwester]

https://bugs.kde.org/show_bug.cgi?id=331597

--- Comment #17 from Michal Sylwester <msylwester at gmail.com> ---
Seems to work better, except sort by category seems to be broken. Not sure
whether it worked before or not...

Still, few comments:
- I noticed however another problem: many of my albums have default date, which
happens to be the same. These are sorted randomly, and whenever I
expand/collapse an album branch the sort order changes... Would be nice to have
something like "use date first, if not sufficient than use also name"
- The album metadata is only in db. As I sync all metadata to images (in order
to sync the collection between programs/computers) album metadata is not
synced... Perhaps something to think about in future (album metadata sidecar
like? or is this already saved somewhere I missed?) 

- I'm not sure why you insist on putting the specific logic of this sorting
into the generic lessThan instead of using the existing sortRole system. This
forces you to use duplicate code (lessThan is now almost 2 copies of same code,
for PAlbum and other), specialized code in generic class, magic numbers (==0),
hide the sortOrder method by variable, and I suspect this makes a bunch of the
old sortOrder code a dead code. But, well, it works, so perhaps I shouldn't
complain too much :)

-- 
You are receiving this mail because:
You are the assignee for the bug.